Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(TreeView): Update example with duplicate IDs #1306

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

silvalaura
Copy link
Collaborator

Issue: #180

What I did

  • Update docs example where we were repeating an itemId (and itemIds need to be unique for proper behavior)
  • In addition, hiding the isDisabled prop for now because it's not fully implemented. Added a ticket number to the TODOs.

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • [-] I have added tests that prove my fix is effective or that my feature works

How to test

Confirm that for the Basic Usage example in the docs site, the itemIds are all unique. Also confirm that when tabbing into the tree, if you press tab one more time, it navigates out of the tree.

@silvalaura silvalaura self-assigned this Jun 4, 2024
@silvalaura silvalaura requested a review from a team as a code owner June 4, 2024 17:31
Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: b897244

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silvalaura silvalaura force-pushed the docs/treeViewExample branch from 0d86c2f to 623777e Compare June 4, 2024 17:34
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Copy link
Contributor

github-actions bot commented Jun 4, 2024

@silvalaura silvalaura merged commit 4747977 into dev Jun 4, 2024
2 checks passed
@silvalaura silvalaura deleted the docs/treeViewExample branch June 4, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants