Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Modal > Storybook > Inverse example #1181

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix - Modal > Storybook > Inverse example #1181

merged 1 commit into from
Jan 10, 2024

Conversation

chris-cedrone-cengage
Copy link
Collaborator

Issue: # 1173

What I did

  • Fixing inverse example in Storybook

Screenshots:

Modal

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • [N/A] I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • [N/A] I have added tests that prove my fix is effective or that my feature works

How to test

  • Go to Storybook
  • Open Modal > Inverse example
  • Verify text is now white in the Modal body

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: f73d4a0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1181--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1181--upbeat-sinoussi-f675aa.netlify.app

@chris-cedrone-cengage chris-cedrone-cengage merged commit 3fc9e50 into dev Jan 10, 2024
2 checks passed
@chris-cedrone-cengage chris-cedrone-cengage deleted the fix/modalPaddingStorybook branch January 11, 2024 13:49
chris-cedrone-cengage added a commit that referenced this pull request Jan 19, 2024
@chris-cedrone-cengage
Fix - Modal > Storybook > Inverse example (#1181)
a3a2738
silvalaura pushed a commit that referenced this pull request Jan 19, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
5434fbe
silvalaura pushed a commit that referenced this pull request Jan 22, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
049a124
silvalaura pushed a commit that referenced this pull request Jun 5, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
5d40755
silvalaura pushed a commit that referenced this pull request Jun 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
4a553a9
silvalaura pushed a commit that referenced this pull request Jun 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
3085793
silvalaura pushed a commit that referenced this pull request Jun 20, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
71e1cbf
silvalaura pushed a commit that referenced this pull request Aug 15, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
9272c3a
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
65ecbf6
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
5fa13d9
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
69e8941
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
f33afb9
silvalaura pushed a commit that referenced this pull request Dec 16, 2024
@chris-cedrone-cengage @silvalaura
Fix - Modal > Storybook > Inverse example (#1181)
b749fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvalaura silvalaura silvalaura approved these changes

@orion-cengage orion-cengage orion-cengage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-cedrone-cengage @orion-cengage @silvalaura