Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Native Select / Select - Additional Content redundancy / CSS #1168

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix - Native Select / Select - Additional Content redundancy / CSS #1168

merged 2 commits into from
Nov 30, 2023

Conversation

chris-cedrone-cengage
Copy link
Collaborator

Issue: # 1114

What I did

  • Fixed icon alignment per Orion's review with Select component using additional content
  • Fixed duplicate content within Native Select

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • [N/A] I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • [N/A] I have added tests that prove my fix is effective or that my feature works

How to test

  • In Docs > Native Select > Additional Content > Make sure help glyph isn't showing up twice under "Default positioning"
  • In Docs > Select > Additional Content > Ensure glyph spacing alignment is akin to the Native Select and Input versions of their respective Additional Content / Children examples.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: dbf97f3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

silvalaura
silvalaura approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@silvalaura silvalaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will wait for the build for Orion's approval

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1168--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1168--upbeat-sinoussi-f675aa.netlify.app

@chris-cedrone-cengage chris-cedrone-cengage merged commit 5e438ab into dev Nov 30, 2023
2 checks passed
@silvalaura silvalaura deleted the fix/additionalContent branch November 30, 2023 20:55
chris-cedrone-cengage added a commit that referenced this pull request Jan 19, 2024
@chris-cedrone-cengage
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
bb7ce13 
…1168)
silvalaura pushed a commit that referenced this pull request Jan 19, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
b633c33 
…1168)
silvalaura pushed a commit that referenced this pull request Jan 22, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
8f09b0e 
…1168)
silvalaura pushed a commit that referenced this pull request Jun 5, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
daac8fc 
…1168)
silvalaura pushed a commit that referenced this pull request Jun 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
86b28d3 
…1168)
silvalaura pushed a commit that referenced this pull request Jun 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
da00106 
…1168)
silvalaura pushed a commit that referenced this pull request Jun 20, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
722c34b 
…1168)
silvalaura pushed a commit that referenced this pull request Aug 15, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
f113a14 
…1168)
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
ffec3c9 
…1168)
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
640b8ae 
…1168)
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
10ad331 
…1168)
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
a45b4cc 
…1168)
silvalaura pushed a commit that referenced this pull request Sep 18, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
c617f3a 
…1168)
silvalaura pushed a commit that referenced this pull request Dec 16, 2024
@chris-cedrone-cengage @silvalaura
Fix - Native Select / Select - Additional Content redundancy / CSS (#…
28e262a 
…1168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvalaura silvalaura silvalaura approved these changes

@orion-cengage orion-cengage orion-cengage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-cedrone-cengage @orion-cengage @silvalaura