Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Dropdown - Removing docs and storybook examples of the Dropdown form #1148

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

chris-cedrone-cengage
Copy link
Collaborator

Issue: # 1014

What I did

  • Removed Dropdown with Form example in docs under Dropdown
  • Removed Form example in Storybook under Dropdown

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • [N/A] I have added tests that prove my fix is effective or that my feature works

How to test

-Confirm docs example of Dropdown with Form example is removed under Dropdown without Menu Items.
-Confirm Storybook example of Form is no longer under the Dropdown examples.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 345acce

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@silvalaura silvalaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@silvalaura silvalaura merged commit f14ff08 into dev Oct 20, 2023
1 check passed
@silvalaura silvalaura deleted the fix/dropdownDocs branch October 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants