Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StyledLabel/TabPanel): Update various labels and TabPanel content to be neutral700 #1140

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

silvalaura
Copy link
Collaborator

Issue: none

What I did

  • Our docs site content, which is inside a TabPanel was using neutral500 instead of neutral700
  • Labels for our form elements were using neutral500 instead of neutral700

Screenshots:

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • [-] I have added tests that prove my fix is effective or that my feature works

How to test

This change affects:

  • Checkbox
  • IndeterminateCheckbox
  • Label
  • Radio
  • Toggle
  • Tabs

@silvalaura silvalaura self-assigned this Oct 3, 2023
@silvalaura silvalaura requested a review from a team as a code owner October 3, 2023 17:59
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: dd1abd0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Copy link
Contributor

@orion-cengage orion-cengage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@silvalaura silvalaura merged commit bc41046 into dev Oct 3, 2023
1 check passed
@silvalaura silvalaura deleted the fix/styledLabelTabContent branch October 3, 2023 18:57
@orion-cengage
Copy link
Contributor

I have verified all of the page text and radio/checkbox labels are displaying in the correct color.

image

silvalaura added a commit that referenced this pull request Oct 9, 2023
silvalaura added a commit that referenced this pull request Oct 23, 2023
silvalaura added a commit that referenced this pull request Jun 5, 2024
silvalaura added a commit that referenced this pull request Aug 15, 2024
silvalaura added a commit that referenced this pull request Sep 18, 2024
silvalaura added a commit that referenced this pull request Sep 18, 2024
silvalaura added a commit that referenced this pull request Sep 18, 2024
silvalaura added a commit that referenced this pull request Sep 18, 2024
silvalaura added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants