fix(RadioGroup): Radio Group label is now a span to improve a11y #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ed9d56 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chris-cedrone-cengage
approved these changes
Oct 3, 2023
|
Looks good here! |
silvalaura
added a commit
that referenced
this pull request
Oct 9, 2023
silvalaura
added a commit
that referenced
this pull request
Oct 23, 2023
silvalaura
added a commit
that referenced
this pull request
Jun 5, 2024
silvalaura
added a commit
that referenced
this pull request
Aug 15, 2024
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
added a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
added a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
What I did
Label inside RadioGroup is a span instead of a label.
Screenshots:
Checklist
How to test
Confirm a11y passes for RadioGroup