Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropdownContent): Handle false as child #1137

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(DropdownContent): Handle false as child #1137

merged 1 commit into from
Oct 2, 2023

Conversation

silvalaura
Copy link
Collaborator

Issue: #1131

What I did

Add support for false as a child of DropdownContent

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

How to test

Ensure that the following code works:

<Dropdown>
  <DropdownButton>Basic Dropdown</DropdownButton>
    <DropdownContent>
    {false && <DropdownMenuItem>Menu item 1</DropdownMenuItem>}
    <DropdownMenuItem>Menu item number two</DropdownMenuItem>
    <DropdownMenuItem disabled>Disabled item</DropdownMenuItem>
  </DropdownContent>
</Dropdown>

@silvalaura silvalaura requested a review from a team as a code owner September 20, 2023 20:18
@silvalaura silvalaura self-assigned this Sep 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 827dcef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silvalaura silvalaura linked an issue Sep 20, 2023 that may be closed by this pull request
DropdownContent doesn't handle "false" as child #1131
Closed
@github-actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1137--upbeat-sinoussi-f675aa.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1137--upbeat-sinoussi-f675aa.netlify.app

@silvalaura silvalaura changed the title fix(DropdownContent): Handle as child fix(DropdownContent): Handle false as child Sep 27, 2023
@github-actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1137--upbeat-sinoussi-f675aa.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1137--upbeat-sinoussi-f675aa.netlify.app

@silvalaura silvalaura merged commit caa2c7b into dev Oct 2, 2023
2 checks passed
@silvalaura silvalaura deleted the fix/dropdownContentChild branch October 2, 2023 19:09
silvalaura added a commit that referenced this pull request Oct 9, 2023
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
8631ab4
silvalaura added a commit that referenced this pull request Oct 23, 2023
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
125c5d9
silvalaura added a commit that referenced this pull request Jun 5, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
866a2a7
silvalaura added a commit that referenced this pull request Aug 15, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
0a050e4
silvalaura added a commit that referenced this pull request Sep 18, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
7795fe5
silvalaura added a commit that referenced this pull request Sep 18, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
db27b0f
silvalaura added a commit that referenced this pull request Sep 18, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
f74eb6e
silvalaura added a commit that referenced this pull request Sep 18, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
0ae7af0
silvalaura added a commit that referenced this pull request Dec 16, 2024
@silvalaura
fix(DropdownContent): Handle false as child (#1137)
f383aa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-cedrone-cengage chris-cedrone-cengage chris-cedrone-cengage approved these changes

Assignees

@silvalaura silvalaura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropdownContent doesn't handle "false" as child
2 participants
@silvalaura @chris-cedrone-cengage