oops

cengage · Oct 20, 2023 · a57fd53 · a57fd53
1 parent 8bfc6e7
commit a57fd53
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/.changeset/dropdown-menuItemRole.md b/.changeset/dropdown-menuItemRole.md
@@ -2,4 +2,4 @@
 'react-magma-dom': patch
 ---
 
-fix(DropdownExpandableMenuItem): Add role
+fix(DropdownExpandableMenuListItem): Add `role="menuitem"`
diff --git a/packages/react-magma-dom/src/components/Dropdown/DropdownExpandableMenuItem.tsx b/packages/react-magma-dom/src/components/Dropdown/DropdownExpandableMenuItem.tsx
@@ -27,13 +27,7 @@ export const DropdownExpandableMenuItem = React.forwardRef<
 
   return (
     <DropdownExpandableMenuItemContext.Provider value={{ disabled }}>
-      <AccordionItem
-        {...other}
-        isDisabled={disabled}
-        ref={ref}
-        testId={testId}
-        role="menuitem"
-      >
+      <AccordionItem {...other} isDisabled={disabled} ref={ref} testId={testId}>
         {children}
       </AccordionItem>
     </DropdownExpandableMenuItemContext.Provider>

diff --git a/packages/react-magma-dom/src/components/Dropdown/DropdownExpandableMenuListItem.tsx b/packages/react-magma-dom/src/components/Dropdown/DropdownExpandableMenuListItem.tsx
@@ -58,6 +58,7 @@ export const DropdownExpandableMenuListItem = React.forwardRef<
       isExpandablePanel={menuGroupContext.isExpandablePanel}
       ref={expandableMenuItemContext.disabled ? null : ref}
       theme={theme}
+      role="menuitem"
     >
       {children}
     </StyledDropdownMenuItem>