Skip to content

Commit

Permalink
fix(NativeSelect): Add aria-describedby to helper and error message…
Browse files Browse the repository at this point in the history
…s to associate them with the `Select`. (#1530)

Co-authored-by: Nikita Orliak <[email protected]>
  • Loading branch information
nikitaorliak-cengage and Nikita Orliak authored Dec 16, 2024
1 parent b37927b commit 4484ad2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-magma-dom': patch
---

fix(NativeSelect): Add `aria-describedby` to helper and error messages to associate them with the `Select`.
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export const NativeSelect = React.forwardRef<HTMLDivElement, NativeSelectProps>(
>
<StyledNativeSelect
data-testid={testId}
aria-describedby={`${id}__desc`}
hasError={!!errorMessage}
disabled={disabled}
id={id}
Expand Down

2 comments on commit 4484ad2

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.