do not check for transportType on transaction update

celzero · Sep 20, 2023 · ed99a59 · ed99a59
1 parent e705e01
commit ed99a59
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/app/src/main/java/com/celzero/bravedns/net/doh/Transaction.kt b/app/src/main/java/com/celzero/bravedns/net/doh/Transaction.kt
@@ -62,10 +62,6 @@ class Transaction {
         DNS_CRYPT(Dnsx.DNSCrypt),
         DNS_PROXY(Dnsx.DNS53);
 
-        fun isDnsCrypt(): Boolean {
-            return this == DNS_CRYPT
-        }
-
         companion object {
             fun getType(type: String): TransportType {
                 return when (type) {

diff --git a/app/src/main/java/com/celzero/bravedns/service/DnsLogTracker.kt b/app/src/main/java/com/celzero/bravedns/service/DnsLogTracker.kt
@@ -91,12 +91,7 @@ internal constructor(
 
         dnsLog.blockLists = transaction.blocklist
         dnsLog.resolverId = transaction.id
-        if (transaction.transportType.isDnsCrypt()) {
-            dnsLog.relayIP = transaction.relayName
-        } else {
-            // fixme: handle for DoH and Dns proxy
-            dnsLog.relayIP = ""
-        }
+        dnsLog.relayIP = transaction.relayName
         dnsLog.dnsType = transaction.transportType.ordinal
         dnsLog.latency = transaction.responseTime
         dnsLog.queryStr = transaction.name