RPC API compatibility test #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
reviewed
Sep 18, 2024
| for _, tx := range r.celoTxs { | ||
| // This sets the y value to be a big number where abs is nul rather than a zero length array if the numebr is zero. | ||
| // It doesn't change the number but it does change the representation. | ||
| types.SetYNullStyleBigIfZero(tx) |
There was a problem hiding this comment.
Somehow I don't see where SetYNullStyleBigIfZero is defined.
There was a problem hiding this comment.
My mistake, when I enabled the build tag it disabled static analysis for the test, meaning when I checked for usages of SetYNullStyleBigIfZero I found none, when in fact the test was calling it. Will reinstate.
Co-authored-by: Karl Bartel <[email protected]>
Co-authored-by: Karl Bartel <[email protected]>
Co-authored-by: Karl Bartel <[email protected]>
Co-authored-by: Karl Bartel <[email protected]>
introduced in a851e39 This is pretty sketchy but there doesn't seem to be a nice way to do this, there's an open issue for this issue right now. google/go-cmp#326
|
@karlb, unfortunately celo8 pulled in a change which has broken the test. It's the use of new atomic types such as My next approach would be to write some manual comparison functions for transactions blocks and headers, unless you have any better ideas. |
Disappointingly, I don't see a better way to do it. Explicit comparison functions seem to be the way to go. |
|
Hi @karlb I've updated the test now to use manual comparison functions for blocks and transactions. Also I added a "fix" for json unmarshaling transactions received from the celo node. That "fix" can be removed once we have done all the migrations we need to do. |
karlb
approved these changes
Sep 24, 2024
We need to be able to support json decoding celo legacy transactions from a celo node to allow the comparison test to fetch and compare transactions from both celo and op-geth nodes. Unfortunately due to C compilation issues it's not feasible to import and use the celo ethclient.Client for this.
piersy
force-pushed
the
piersy/rpc-api-compatibility-test
branch
from
b3354ec to
9b18b54
Compare
piersy
added a commit
that referenced
this pull request
Oct 3, 2024
Adds a test which compares the RPC API outputs of a celo-blockchain node
and an op-geth node using a migrated version of the datadir used by the
celo node.
The test is segregated from normal compilation by the build tag
'compat_test'.
The intent of this test is to ensure that our cel2 nodes will return rpc
api responses for historical data that are consistent with the
celo-blockchain node.
Run it like this:
go test -v ./compat_test -tags compat_test -celo-url '<celo rpc url>' -op-geth-url '<op-geth rpc url>'
The build tag disables static analysis in vscode so if you still want
that you need to add the build tag to your preferences:
{
...
"go.buildTags": "compat_test",
...
}
Also updates json transaction unmarshaling to be able to handle
unmarshaling from a celo-node, and adds a utility function in the types
package to help make transactions comparable. We'll want to remove these
at a later date since they exist solely support running this test.
Co-authored-by: Karl Bartel <[email protected]>
karlb
added a commit
that referenced
this pull request
Oct 11, 2024
Adds a test which compares the RPC API outputs of a celo-blockchain node
and an op-geth node using a migrated version of the datadir used by the
celo node.
The test is segregated from normal compilation by the build tag
'compat_test'.
The intent of this test is to ensure that our cel2 nodes will return rpc
api responses for historical data that are consistent with the
celo-blockchain node.
Run it like this:
go test -v ./compat_test -tags compat_test -celo-url '<celo rpc url>' -op-geth-url '<op-geth rpc url>'
The build tag disables static analysis in vscode so if you still want
that you need to add the build tag to your preferences:
{
...
"go.buildTags": "compat_test",
...
}
Also updates json transaction unmarshaling to be able to handle
unmarshaling from a celo-node, and adds a utility function in the types
package to help make transactions comparable. We'll want to remove these
at a later date since they exist solely support running this test.
Co-authored-by: Karl Bartel <[email protected]>
piersy
added a commit
that referenced
this pull request
Oct 15, 2024
Adds a test which compares the RPC API outputs of a celo-blockchain node
and an op-geth node using a migrated version of the datadir used by the
celo node.
The test is segregated from normal compilation by the build tag
'compat_test'.
The intent of this test is to ensure that our cel2 nodes will return rpc
api responses for historical data that are consistent with the
celo-blockchain node.
Run it like this:
go test -v ./compat_test -tags compat_test -celo-url '<celo rpc url>' -op-geth-url '<op-geth rpc url>'
The build tag disables static analysis in vscode so if you still want
that you need to add the build tag to your preferences:
{
...
"go.buildTags": "compat_test",
...
}
Also updates json transaction unmarshaling to be able to handle
unmarshaling from a celo-node, and adds a utility function in the types
package to help make transactions comparable. We'll want to remove these
at a later date since they exist solely support running this test.
Co-authored-by: Karl Bartel <[email protected]>
piersy
added a commit
that referenced
this pull request
Oct 15, 2024
Adds a test which compares the RPC API outputs of a celo-blockchain node
and an op-geth node using a migrated version of the datadir used by the
celo node.
The test is segregated from normal compilation by the build tag
'compat_test'.
The intent of this test is to ensure that our cel2 nodes will return rpc
api responses for historical data that are consistent with the
celo-blockchain node.
Run it like this:
go test -v ./compat_test -tags compat_test -celo-url '<celo rpc url>' -op-geth-url '<op-geth rpc url>'
The build tag disables static analysis in vscode so if you still want
that you need to add the build tag to your preferences:
{
...
"go.buildTags": "compat_test",
...
}
Also updates json transaction unmarshaling to be able to handle
unmarshaling from a celo-node, and adds a utility function in the types
package to help make transactions comparable. We'll want to remove these
at a later date since they exist solely support running this test.
Co-authored-by: Karl Bartel <[email protected]>
karlb
added a commit
that referenced
this pull request
Dec 13, 2024
Adds a test which compares the RPC API outputs of a celo-blockchain node
and an op-geth node using a migrated version of the datadir used by the
celo node.
The test is segregated from normal compilation by the build tag
'compat_test'.
The intent of this test is to ensure that our cel2 nodes will return rpc
api responses for historical data that are consistent with the
celo-blockchain node.
Run it like this:
go test -v ./compat_test -tags compat_test -celo-url '<celo rpc url>' -op-geth-url '<op-geth rpc url>'
The build tag disables static analysis in vscode so if you still want
that you need to add the build tag to your preferences:
{
...
"go.buildTags": "compat_test",
...
}
Also updates json transaction unmarshaling to be able to handle
unmarshaling from a celo-node, and adds a utility function in the types
package to help make transactions comparable. We'll want to remove these
at a later date since they exist solely support running this test.
Co-authored-by: Karl Bartel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that is segregated from normal compilation by a build tag which compares the RPC API outputs of a celo-blockchain node and an op-geth node using a migrated version of the datadir used by the celo node.
The intent is to ensure that our cel2 nodes will return rpc api responses for historical data that are consistent with the celo-blockchain node.
Run it like this:
The build tag disables static analysis in vscode so if you still want that you need to add the build tag to your preferences:
Closes https://github.com/celo-org/celo-blockchain-planning/issues/363