Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Embedding makerdojo (#750)" #966

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

arthurgousset
Copy link

@arthurgousset arthurgousset commented Sep 26, 2023

Description

This reverts commit 22bb0f1.

Motivation

Removing Makerdojo stats page and dropdown from explorer.celo.org

Changelog

Quick attempt at reverting pull request

without installing entire local development environment. A few merge conflicts make me think the git revert operation might mess things up, but hoping to check how tests run in the Github Actions CI, rather than setting things up locally.

Git reverts the following PR #750 and resolves a few merge conflicts on best effort basis (this is a hacky test).

Tested

Not tested locally, because local Blockscout development environment is not set up.

Issues

Fixes:

This reverts commit 22bb0f1.

Quick attempt at reverting pull request #750 without installing entire local development requirements.
A few merge conflicts make me think the git revert operation might mess things up.:
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Unit Test Results

       6 files     366 suites   3m 49s ⏱️
2 641 tests 2 567 ✔️ 74 💤 0
2 655 runs  2 579 ✔️ 76 💤 0

Results for commit 0a14aa8.

♻️ This comment has been updated with latest results.

@arthurgousset
Copy link
Author

arthurgousset commented Sep 28, 2023

@shazarre deployed this to the staging environment and we both visually QA'ed the deployment there.

  • There is no drop down anymore
    image
  • The page explorer.celo.org/mainnet/makerdojo doesn't exist
    image

@arthurgousset arthurgousset marked this pull request as ready for review September 28, 2023 09:47
@arthurgousset arthurgousset requested a review from a team as a code owner September 28, 2023 09:47
@arthurgousset arthurgousset requested review from rkachowski and removed request for shazarre September 28, 2023 09:57
@arthurgousset arthurgousset merged commit f56376a into master Sep 28, 2023
23 checks passed
@arthurgousset arthurgousset deleted the 0xarthurxyz/remove-makerdojo branch September 28, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants