Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload celo_account on AddressReadProxyController when available. #1003

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

rkachowski
Copy link

Description

The application is crashing when trying to display data it has not loaded from the database (specifically celo epoch data). This PR adds an optional preload to the db fetch to include celo_accounts information should it exist for the address being fetched.

Tested

Issues

@rkachowski rkachowski requested a review from a team as a code owner December 14, 2023 11:36
@rkachowski rkachowski requested a review from lvpeschke December 14, 2023 11:36
@rkachowski rkachowski self-assigned this Dec 14, 2023
Copy link

Unit Test Results

       5 files  ±0     363 suites  ±0   3m 30s ⏱️ -2s
2 637 tests ±0  2 563 ✔️ ±0  74 💤 ±0  0 ±0 
2 651 runs  ±0  2 575 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit 1920124. ± Comparison against base commit 590d02e.

@rkachowski rkachowski merged commit 0a3f43c into master Dec 14, 2023
23 checks passed
@rkachowski rkachowski deleted the dhutch/read_proxy_fix branch December 14, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants