Patch external_url method to constrain set of valid uris #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkachowski
changed the title
alvarof2
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patches the
external_urlmethod inapps/block_scout_web/lib/block_scout_web/views/tokens/instance/overview_view.exto only consider urls that begin withhttpas valid. This allows both "http" and "https" external urls to be rendered within the page and treats any other uri as missing.This is needed to prevent a reported XSS exploit whereby an NFT encoded a
javascript:eval('blah')within theexternal_urlcontent of it's own metadata.Other changes
Minor whitespace changes
Tested
Issues