Code

Added an Analyser class#631

Code

Merged

agarny merged 248 commits intocellml:developcellml/libcellml:developfrom agarny:issue499agarny/libcellml:issue499Copy head branch name to clipboardSep 30, 2020

+9,327-6,373

Commits

Commits on Jun 16, 2020

• Analyser: skeleton for our analyser class and test.

  agarny

  committed
  168d016

• Analyser: added a test for an empty model.

  agarny

  committed
  efa318b

• Make ClangFormat happy.

  agarny

  committed
  a27df70

• Some minor cleaning up.

  agarny

  committed
  d183e7e

• Analyser: test for an initialised VOI.

  agarny

  committed
  b8868ae

• Merge branch 'develop' into issue499.

  agarny

  committed
  6a4499c

Commits on Jun 19, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  e0248f4

Commits on Jun 21, 2020

• Some minor cleaning up.

  agarny

  committed
  5ff80f8

• Analyser: make sure that a model is valid before processing it.

  agarny

  committed
  a64d1ac

• Analyser: make our emptyModel pass.

  Show description for c2409b1
  agarny

  committed
  c2409b1

Commits on Jun 22, 2020

• Analyser: moved all/most of the analysis code from the Generator class to the Analyser class.

  agarny

  committed
  d64ccb9

• Make ClangFormat happy.

  agarny

  committed
  3e91cae

• Debug: have printAst() now use of our new AnalyserEquationAst class.

  agarny

  committed
  0f3bb44

• Generator: removed the emptyModel() and initializedVariableOfIntegration() tests.

  Show description for 77b057e
  agarny

  committed
  77b057e

• Analyser: moved some Generator tests that are actually analysis tests.

  agarny

  committed
  fa749da

• Some minor cleaning up.

  agarny

  committed
  b018d1b

• Analyser: added an AnalyserModel class.

  agarny

  committed
  e66a48e

Commits on Jun 23, 2020

• Some minor cleaning up.

  agarny

  committed
  f2fbb8b

• Some minor cleaning up.

  agarny

  committed
  5fc50a6

• Some minor cleaning up.

  agarny

  committed
  1e1e25c

• Some minor cleaning up.

  agarny

  committed
  d036575

• Generator: don't use internal data.

  agarny

  committed
  8db6248

• Some minor cleaning up.

  agarny

  committed
  31af8f6

• Analyser variable: provide index value.

  agarny

  committed
  9386de0

• Generator: don't use internal data.

  agarny

  committed
  a94c37a

• Some minor cleaning up.

  agarny

  committed
  1fc4578

• Some minor cleaning up.

  agarny

  committed
  5d24b9f

Commits on Jun 24, 2020

• Generator: created and use the GeneratorEquation class.

  agarny

  committed
  2e1976e

• Debug: removed printAst().

  Show description for 62100d6
  agarny

  committed
  62100d6

• Some minor cleaning up.

  agarny

  committed
  13962c6

• Analyser: skeleton of the AnalyserEquation class.

  agarny

  committed
  82658ca

• Analyser: removed the create() method from the AnalyserModel and AnalyserVariable classes.

  Show description for a5e4e04
  agarny

  committed
  a5e4e04

• Some minor cleaning up.

  agarny

  committed
  36023ab

• Analyser: converting AnalyserEquationAst to an API class.

  agarny

  committed
  294a449

• Some minor cleaning up.

  agarny

  committed
  3185f3e

• Analyser: implemented the AnalyserEquation class.

  agarny

  committed
  67f9fc8

Commits on Jun 25, 2020

• Debug: put back printAst().

  Show description for a27ad7d
  agarny

  committed
  a27ad7d

• Generator: removed the analysis code from it.

  agarny

  committed
  7e3803d

• Generator: added a test for coverage purposes.

  agarny

  committed
  103deb8

• Some minor cleaning up.

  agarny

  committed
  05ee73e

• Generator: reworked the code a bit for coverage purposes.

  Show description for 8e910ea
  agarny

  committed
  8e910ea

• Some minor cleaning up.

  agarny

  committed
  627bd4a

• Analyser: some coverage tests.

  agarny

  committed
  2878994

• Some minor cleaning up.

  agarny

  committed
  66807c0

• Generator: removed an old Python GeneratorVariable test.

  agarny

  committed
  09f5726

• SWIG: updated some interfaces and created some new ones.

  agarny

  committed
  8852221

• Merge branch 'develop' into issue499.

  agarny

  committed
  9a8d391

• Python bindings: updated our __init__.py file.

  agarny

  committed
  9cfd681

• Some minor cleaning up.

  agarny

  committed
  f3f46a2

Commits on Jun 26, 2020

• Some minor cleaning up.

  agarny

  committed
  c4b58c5

• Some minor cleaning up.

  agarny

  committed
  326f4df

• Some minor cleaning up.

  agarny

  committed
  e95ff4b

• SWIG: cleaned up / added some interfaces.

  agarny

  committed
  2628fe6

Commits on Jun 29, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  64cebfb

• Some minor cleaning up.

  agarny

  committed
  9301f21

• Analyser: added a couple of methods to go from an AnalyserVariable to an AnalyserEquation and vice versa.

  agarny

  committed
  c361093

• Make GCC coverage happy.

  Show description for 9b6bc20
  agarny

  committed
  9b6bc20

• Make memcheck happy.

  agarny

  committed
  25edc9b

• Disable most tests.

  agarny

  committed
  d0ac8fa

• test

  agarny

  committed
  582d128

• test

  agarny

  committed
  8de3c09

• test

  agarny

  committed
  52699eb

• test

  agarny

  committed
  5e34092

• test

  agarny

  committed
  6adf4a3

• Analyser: create a proper shared pointer.

  agarny

  committed
  3f06986

• Some minor cleaning up.

  Show description for b0583d2
  agarny

  committed
  b0583d2

• Merge branch 'issue499' into temp.

  agarny

  committed
  304c2c0

• test

  agarny

  committed
  41f83cb

• test

  agarny

  committed
  f584131

Commits on Jun 30, 2020

• test

  agarny

  committed
  714b5fd

• Some minor cleaning up.

  agarny

  committed
  dd61307

• Analyser: create a proper shared pointer.

  agarny

  committed
  785c0c9

• Analyser: make our consistent.

  agarny

  committed
  a6b6994

• Analyser: replaced static create() methods with private populate() ones.

  Show description for 0d92e92
  agarny

  committed
  0d92e92

• Analyser: replaced static create() methods with private populate() ones.

  Show description for 30b8d27
  agarny

  committed
  30b8d27

• Merge branch 'issue499' into temp.

  agarny

  committed
  7e2d89d

• Some minor cleaning up.

  Show description for 27bc41a
  agarny

  committed
  27bc41a

• Oops, had committed some code that disabled some tests!

  Show description for 8defb31
  agarny

  committed
  8defb31

• Some minor cleaning up.

  agarny

  committed
  65f934f

• Revert "Oops, had committed some code that disabled some tests!"

  Show description for e9687ab
  agarny

  committed
  e9687ab

• Some minor cleaning up.

  agarny

  committed
  35c799f

• Analyser: make memcheck happy by avoiding circular referencing.

  agarny

  committed
  2fb32ce

• Re-enable all of our tests.

  agarny

  committed
  06e91ff

• Merge branch 'develop' into issue499.

  agarny

  committed
  1d8a7bd

• Merge branch 'temp' into issue499.

  agarny

  committed
  71e5d13

• Python: slight reworking of the generator profile test.

  agarny

  committed
  2d82138

Commits on Jul 1, 2020

• Some minor cleaning up.

  agarny

  committed
  c1c9e21

• Analyser: added a Python test for the AnalyserEquationAst class.

  agarny

  committed
  33edfa6

• Analyser: added a Python test for testing the Analyser's inheritance.

  agarny

  committed
  fd849b2

• Some minor cleaning up.

  agarny

  committed
  fde13a9

• Analyser: added a comment to the test_process_model Python test.

  agarny

  committed
  6f3a1ff

• Interfaces: some minor cleaning up for the Analyser and Generator classes.

  agarny

  committed
  86f7324

• Merge branch 'develop' into issue499.

  agarny

  committed
  b696f26

Commits on Jul 2, 2020

• Analyser: renamed a couple of functions for consistency with the rest of our codebase.

  agarny

  committed
  17707a8

• Analyser: renamed a couple of functions for consistency with the rest of our codebase.

  agarny

  committed
  4125353

• Fixed a typo.

  agarny

  committed
  a6c0aac

• Use British English.

  agarny

  committed
  51fb4ad

• Fixed a typo.

  agarny

  committed
  0d22590

• Analyser: minor reworking of code.

  agarny

  committed
  dc6c820

• Analyser: fixed the documentation.

  agarny

  committed
  db958d8

• AnalyserEquation: fixed the documentation.

  agarny

  committed
  3bfe97e

• AnalyserEquationAst: fixed the documentation.

  agarny

  committed
  1983a4c

• Replaced "lower" with "less" across our documentation.

  Show description for 681209c
  agarny

  committed
  681209c

• Use "[less|greater] than or equal to".

  agarny

  committed
  e2600fb

• Double quote function/operator names.

  agarny

  committed
  4762f45

• Issue: properly order causes.

  agarny

  committed
  cbe514c

• Utilities: updated the documentation for isSameOrEquivalentVariable().

  agarny

  committed
  c253986

• Analyser: don't set the cause of an issue.

  Show description for 395a18e
  agarny

  committed
  395a18e

• Generator: don't make it a logger anymore.

  agarny

  committed
  577e1af

• Generator: don't make it a logger anymore.

  agarny

  committed
  f8278f0

• SWIG: sorted out our types.

  agarny

  committed
  0e5bad4

• SWIG: fixed the Prefix enum.

  agarny

  committed
  27e86f0

• SWIG: added the check for the Issue::Level enum.

  agarny

  committed
  5027d33

• SWIG: removed the check for Generator::ModelType since it doesn't exist anymore.

  agarny

  committed
  80cffc0

• SWIG: added checks for AnalyserEquationAst::Type, AnalyserModel::Type and AnalyserVariable::Type.

  agarny

  committed
  c9f1e4b

Commits on Jul 3, 2020

• Some minor cleaning up.

  agarny

  committed
  1a79518

• SWIG: removed checks for AnalyserModel::Type and AnalyserVariable::Type.

  Show description for f922c9a
  agarny

  committed
  f922c9a

• SWIG: use $type rather than the type itself.

  Show description for bf8780c
  agarny

  committed
  bf8780c

Commits on Jul 5, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  f9f8c88

• Use British spelling.

  agarny

  committed
  7f08c87

Commits on Jul 6, 2020

• Removed some debug code.

  agarny

  committed
  ff355d8

Commits on Jul 7, 2020

• Some minor cleaning up.

  agarny

  committed
  e741b7c

• Analyser: don't make the AnalyserEquationAst class a friend of the Generator class.

  Show description for b6296cc
  agarny

  committed
  b6296cc

• Some minor cleaning up in our Analyser tests.

  agarny

  committed
  e18203e

• Analyser: remove model information from error messages.

  Show description for 0b6baf7
  agarny

  committed
  0b6baf7

Commits on Jul 9, 2020

• Merge branch 'issue313' into issue499.

  agarny

  committed
  df4f564

• Analyser/Generator: made use of auto as much as possible.

  agarny

  committed
  fb3cda2

• Some minor cleaning up.

  agarny

  committed
  e7070d5

Commits on Jul 10, 2020

• Some minor cleaning up.

  agarny

  committed
  79b2215

• Some minor cleaning up.

  agarny

  committed
  bdb1144

• AnalyserEquationAst: track its corresponding AnalyserVariablePtr, not its corresponding VariablePtr.

  Show description for 2bf01bf
  agarny

  committed
  2bf01bf

• Some minor cleaning up.

  agarny

  committed
  17702c6

• Revert "AnalyserEquationAst: track its corresponding AnalyserVariablePtr, not its corresponding VariablePtr."

  Show description for 40eb8fe
  agarny

  committed
  40eb8fe

Commits on Jul 13, 2020

• Merge branch 'issue655' into issue499.

  agarny

  committed
  77adf3b

• AnalyserEquationAst: removed a method that we don't use anymore.

  agarny

  committed
  f1ded05

• Merge branch 'issue313' into issue499.

  agarny

  committed
  3194f49

• Some minor cleaning up.

  agarny

  committed
  733e7c0

• Merge branch 'issue313' into issue499.

  agarny

  committed
  2df5024

Commits on Jul 14, 2020

• Merge branch 'issue313' into issue499.

  agarny

  committed
  6b0b7e9

• Analyser: added a meaningful cause to the issues generated by the analyser.

  agarny

  committed
  c78a14c

Commits on Jul 15, 2020

• Analyser: renamed processModel() to analyseModel().

  Show description for 5455625
  agarny

  committed
  5455625

• Merge branch 'develop' into issue499

  nickerso

  authored
  6188519

Commits on Jul 16, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  bc7f939

Commits on Jul 17, 2020

• Generator: made some implementation methods constant.

  agarny

  committed
  acfb589

Commits on Jul 20, 2020

• Merge branch 'issue665' into issue499.

  agarny

  committed
  6826fcb

• Merge branch 'issue665' into issue499.

  agarny

  committed
  1cf9251

Commits on Jul 22, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  b3f9c03

• Merge branch 'develop' into issue499.

  agarny

  committed
  4ecbc18

Commits on Jul 23, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  d083583

Commits on Jul 28, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  d4e40d8

• Merge branch 'issue672' into issue499.

  agarny

  committed
  2be8f89

Commits on Jul 29, 2020

• Merge branch 'issue672' into issue499.

  agarny

  committed
  0de2436

• Merge branch 'develop' into issue499.

  agarny

  committed
  54bc8cf

• Merge branch 'develop' into issue499.

  agarny

  committed
  7b80a4e

Commits on Jul 30, 2020

• Analyser: various reworking/improvements of/to the code.

  agarny

  committed
  d783066

Commits on Jul 31, 2020

• AnalyserEquation: fixed a memory leak.

  agarny

  committed
  c36b577

Commits on Aug 1, 2020

• Some minor cleaning up.

  agarny

  committed
  dfec864

Commits on Aug 2, 2020

• GeneratorProfile: updated the documentation.

  agarny

  committed
  d178b98

• Analyser tests: check that the issues are errors.

  agarny

  committed
  7f8a383

• Generator tests: look for errors, not just issues.

  agarny

  committed
  0ad65b2

• Generator tests: slight update to our coverage test.

  agarny

  committed
  4c6f971

Commits on Aug 5, 2020

• Merge branch 'develop' into issue499

  kerimoyle

  authored
  1f70832

• Generator: ensure that we get 100% coverage in our sha1() method.

  agarny

  committed
  e93d316

Commits on Aug 11, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  ffeb8d1

Commits on Aug 12, 2020

• Analyser: explain a bit more what the Analyser class is all about.

  agarny

  committed
  7555d9e

• Generator: replaced occurrences of the "exponential" constant with Euler's number.

  agarny

  committed
  3935a41

• Analyser/Generator: replaced occurrences of equivalence with equal to.

  agarny

  committed
  8b9cf1e

• Analyser/Generator: replaced occurrences of nonequivalence with not equal to.

  agarny

  committed
  96e53b0

• Analyser/Generator: replaced occurrences of xor with exclusive or.

  agarny

  committed
  5de8f11

• Fixed a small typo.

  agarny

  committed
  f1d0e48

Commits on Aug 13, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  0b8c03c

• Merge branch 'develop' into issue499.

  agarny

  committed
  7537550

• FIx type in analyser.h.

  hsorby

  authored
  418adee

Commits on Aug 19, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  7b7020a

• Some minor cleaning up.

  agarny

  committed
  234fd90

• Merge branch 'develop' into issue499

  agarny

  committed
  51cadb5

Commits on Aug 20, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  5ff9965

Commits on Aug 24, 2020

• Analyser: slight improvement to our generation of issues.

  agarny

  committed
  b36380f

Commits on Aug 27, 2020

• Analyser: removed some unneeded code.

  agarny

  committed
  b39767d

• Fixed a typo.

  agarny

  committed
  8f4d590

• Only #undef something if it was previously #define'd.

  agarny

  committed
  8f965cf

• Make ClangFormat happy.

  agarny

  committed
  7c9f32a

• Analyser: renamed compareVariablesByName to compareVariablesByComponentAndName.

  agarny

  committed
  ab0b64f

• Analyser test: check that an issue references a variable with the expected name.

  agarny

  committed
  c3f598e

• GeneratorProfile: clarified the description of some methods.

  agarny

  committed
  e38a5c0

• Analyser/generator: provided some documentation for our enums.

  agarny

  committed
  40a3682

• Update analyser.h

  Show description for cf5cc4e
  hsorby

  authored
  cf5cc4e

Commits on Aug 28, 2020

• Generator: added a model() and setModel() method.

  Show description for 0eccc52
  agarny

  committed
  0eccc52

• Generator: updated our Python test.

  agarny

  committed
  982a609

• Some minor cleaning up.

  agarny

  committed
  05af6ea

Commits on Aug 31, 2020

• Analyser/Generator: use weak pointers where appropriate.

  Show description for 84b6c61
  agarny

  committed
  84b6c61

• Make gcc happy.

  agarny

  committed
  0be267a

Commits on Sep 1, 2020

• Analyser/Generator: simplified our use of weak pointers.

  Show description for ef0e76d
  agarny

  committed
  ef0e76d

• Make both gcc and MSVC happy.

  agarny

  committed
  d73811f

• Analyser: improved a comment.

  agarny

  committed
  0e77fb9

• Analyser: updated some comments.

  agarny

  committed
  e353c92

• Analyser: grammatically improved a comment.

  agarny

  committed
  d98dac4

• Analyser/Generator: slight improvement to our documentation for the create() method.

  agarny

  committed
  5253dcf

• Generator: slight improvement to the documentation for the interfaceCode() and implementationCode() methods.

  agarny

  committed
  9f8363a

• AnalyserModel: clarified the API documentation.

  agarny

  committed
  3ef129d

• AnalyserModel: clarified and added some API documentation.

  agarny

  committed
  6e4a27a

• AnalyserModel interface: removed a duplicate.

  agarny

  committed
  7818039

• AnalyserModel interface: fixed copy/paste gone wrong.

  agarny

  committed
  7db0034

Commits on Sep 2, 2020

• Analyser: account for the fact that a math string may consist of several <math> elements.

  agarny

  committed
  e923d0a

Commits on Sep 3, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  9d23a36

Commits on Sep 7, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  feffc7f

Commits on Sep 9, 2020

• Generator test: fixed a typo.

  agarny

  committed
  83b4049

Commits on Sep 16, 2020

• Analyser: slight improvement to the documentation.

  agarny

  committed
  4c641c3

• Analyser: [co]sine, not [co]sinus.

  agarny

  committed
  0f277e0

• Analyser: fixed a typo in the documentation.

  agarny

  committed
  99112c8

• Analyser: fixed a small problem in the documentation.

  agarny

  committed
  029a447

• Generator: natural, not Napierian logarithm.

  agarny

  committed
  3c803c4

• Analyser: fixed a typo in the documentation.

  agarny

  committed
  240a547

• Analyser: properly handle the analysis of a null model.

  Show description for 3008b3b
  agarny

  committed
  3008b3b

• Merge branch 'develop' into issue499.

  agarny

  committed
  aa84f65

• Merge branch 'develop' into issue499

  agarny

  authored
  5b01f53

• Some minor cleaning up.

  agarny

  committed
  f3b3161

Commits on Sep 17, 2020

• Python: follow PEP8.

  agarny

  committed
  abc7e61

• Generator: fixed interfaces following commit aa84f65.

  agarny

  committed
  ee940e1

• Generator Python test: some minor cleaning up.

  agarny

  committed
  4f855e3

• Merge branch 'issue499' of https://github.com/agarny/libcellml into issue499

  agarny

  committed
  f67dffb

• Generator: fixed interfaces following commit aa84f65.

  agarny

  committed
  43bcde3

• Tests: some minor cleaning up.

  agarny

  committed
  d1cfd35

• Generator: fixed Python tests following commit aa84f65.

  agarny

  committed
  1195243

• Some minor cleaning up.

  agarny

  committed
  ddbea51

• Analyser/Generator: updated our interfaces to get Python coverage.

  agarny

  committed
  1960a52

Commits on Sep 18, 2020

• Analyser/Generator: ensure 100% Python coverage.

  agarny

  committed
  e5528a6

• Analyser: improvement to our Python coverage test.

  agarny

  committed
  582887b

• Analyser: make our bindings aware of our use of std::vector.

  agarny

  committed
  9c5ddf5

• SWIG: bump up our requirements.

  Show description for 4c9583c
  agarny

  committed
  4c9583c

• SWIG: bump up our requirements.

  Show description for f129dc0
  agarny

  committed
  f129dc0

Commits on Sep 21, 2020

• Generator profile Python test: some minor cleaning up.

  agarny

  committed
  f583a0a

• Analyser/generator: cleaned up the docstrings for our interfaces.

  agarny

  committed
  4fb3309

• Generator interface: some minor cleaning up.

  agarny

  committed
  6986509

Commits on Sep 24, 2020

• Some minor cleaning up.

  agarny

  committed
  04d9f90

Commits on Sep 25, 2020

• Analyser: updated the documentation for Analyser::model().

  agarny

  committed
  49714ac

• AnalyserEquationAst: slight update to our documentation.

  agarny

  committed
  9bc7021

• Utilities: added the replace() method that used to be in our Generator class.

  agarny

  committed
  489939a

• GeneratorProfile Python tests: using Pythonic method names.

  agarny

  committed
  ac7d660

Commits on Sep 29, 2020

• Merge branch 'develop' into issue499.

  agarny

  committed
  03490c6

• Merge branch 'develop' into issue499

  nickerso

  authored
  57a75fe

• Tests: removed the ids from the sine approximations CellML files.

  agarny

  committed
  aa444bd

• Merge branch 'develop' into issue499

  agarny

  authored
  7c78b3e

• Merge branch 'develop' into issue499.

  agarny

  committed
  8d68394

• AnalyserEquationAst: fixed the documentation for DEGREE.

  agarny

  committed
  66027ba

• AnalyserModel: slight update to the isValid() documentation.

  agarny

  committed
  34851a0

• AnalyserModel: slight update to our the voi() documentation.

  agarny

  committed
  851ebb7

• AnalyserVariable: slight update to the Type documentation.

  agarny

  committed
  3503425