Merge pull request #88 from celestiaorg/no-copy-getCell

celestiaorg · May 16, 2022 · 80b016d · 80b016d
2 parents 5dc63b1 + 35aa186
commit 80b016d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/datasquare.go b/datasquare.go
@@ -231,7 +231,7 @@ func (ds *dataSquare) getColRoot(y uint) []byte {
 	return tree.Root()
 }
 
-// getCell returns a single chunk at a specific cell.
+// getCell returns a copy of single chunk at a specific cell.
 func (ds *dataSquare) getCell(x uint, y uint) []byte {
 	if ds.squareRow[x][y] == nil {
 		return nil

diff --git a/extendeddatacrossword.go b/extendeddatacrossword.go
@@ -355,7 +355,7 @@ func (eds *ExtendedDataSquare) computeSharesRoot(shares [][]byte, i uint) []byte
 
 func (eds *ExtendedDataSquare) rowRangeNoMissingData(r, start, end uint) bool {
 	for c := start; c <= end && c < eds.width; c++ {
-		if eds.getCell(r, c) == nil {
+		if eds.squareRow[r][c] == nil {
 			return false
 		}
 	}
@@ -364,7 +364,7 @@ func (eds *ExtendedDataSquare) rowRangeNoMissingData(r, start, end uint) bool {
 
 func (eds *ExtendedDataSquare) colRangeNoMissingData(c, start, end uint) bool {
 	for r := start; r <= end && r < eds.width; r++ {
-		if eds.getCell(r, c) == nil {
+		if eds.squareRow[r][c]  == nil {
 			return false
 		}
 	}