-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: add ci workflows #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but I don't think we need Goreleaser here
.github/workflows/goreleaser.yml
Outdated
@@ -0,0 +1,40 @@ | |||
name: goreleaser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this repo will only contain a Go library, I don't think we need this file because we don't need GoReleaser to create pre-built binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is go releaser just for binaries? I thought it was triggered whenever releases were made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoReleaser can do other things but we only use it for creating binaries in celestia-app
Closes: #6
This PR copies most of the workflows from the celestia-app repo including tests, linting, go releaser etc.
It also sets the code owners and the PR template