Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: add ci workflows #8

Merged
merged 5 commits into from
Jan 6, 2024
Merged

chore!: add ci workflows #8

merged 5 commits into from
Jan 6, 2024

Conversation

cmwaters
Copy link
Collaborator

@cmwaters cmwaters commented Jan 4, 2024

Closes: #6

This PR copies most of the workflows from the celestia-app repo including tests, linting, go releaser etc.

It also sets the code owners and the PR template

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but I don't think we need Goreleaser here

@@ -0,0 +1,40 @@
name: goreleaser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this repo will only contain a Go library, I don't think we need this file because we don't need GoReleaser to create pre-built binaries.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is go releaser just for binaries? I thought it was triggered whenever releases were made

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoReleaser can do other things but we only use it for creating binaries in celestia-app

.github/workflows/ci-release.yml Outdated Show resolved Hide resolved
.github/workflows/issue-label-automation.yml Show resolved Hide resolved
.github/workflows/issue-label-automation.yml Show resolved Hide resolved
.github/workflows/lint-pull-request.yml Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
.github/workflows/project-automation.yml Show resolved Hide resolved
@cmwaters cmwaters requested a review from rootulp January 4, 2024 22:17
@cmwaters cmwaters merged commit 79d147e into main Jan 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI workflows
2 participants