fix!: use squareSizeUpperBound for worstCaseShareIndexes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
staheri14,
ninabarbakadze,
walldiss,
renaynay,
cmwaters and
evan-forbes
and removed request for
a team,
staheri14,
ninabarbakadze,
walldiss and
renaynay
|
Note to reviewers: we could add a unit test to this PR that includes a |
evan-forbes
approved these changes
Mar 7, 2024
|
We could merge this as-is but I want @cmwaters 's review. I'm also nervous about regressions in this repo because this fix was added without a test that would fail if we ever revert this behavior 😞 I'll work on adding a test now. |
|
Closing in favor of #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47
This restores the behavior from celestia-app v1.x where square size upper bound is used to calculate worstCaseShareIndexes.
Testing
In celestia-app, TestMaxBlockSize flake is no longer observed