chore(linter): enable go-critic

.golangci.yml

@@ -11,6 +11,7 @@ linters:
     - revive
     - prealloc
     - stylecheck
+    - gocritic
 
 linters-settings:
   nakedret:

inclusion/commitment.go

@@ -40,7 +40,7 @@ func CreateCommitment(blob *blob.Blob, merkleRootFn MerkleRootFn, subtreeRootThr
 	cursor := uint64(0)
 	for i, treeSize := range treeSizes {
 		leafSets[i] = sh.ToBytes(shares[cursor : cursor+treeSize])
-		cursor = cursor + treeSize
+		cursor += treeSize
 	}
 
 	// create the commitments by pushing each leaf set onto an nmt
@@ -99,14 +99,14 @@ func MerkleMountainRangeSizes(totalSize, maxTreeSize uint64) ([]uint64, error) {
 		switch {
 		case totalSize >= maxTreeSize:
 			treeSizes = append(treeSizes, maxTreeSize)
-			totalSize = totalSize - maxTreeSize
+			totalSize -= maxTreeSize
 		case totalSize < maxTreeSize:
 			treeSize, err := sh.RoundDownPowerOfTwo(totalSize)
 			if err != nil {
 				return treeSizes, err
 			}
 			treeSizes = append(treeSizes, treeSize)
-			totalSize = totalSize - treeSize
+			totalSize -= treeSize
 		}
 	}
 

shares/powers_of_two.go

@@ -10,7 +10,7 @@ import (
 func RoundUpPowerOfTwo[I constraints.Integer](input I) I {
 	var result I = 1
 	for result < input {
-		result = result << 1
+		result <<= 1
 	}
 	return result
 }

shares/share_builder.go

@@ -174,7 +174,7 @@ func (b *Builder) FlipSequenceStart() {
 
 	// the sequence start indicator is the last bit of the info byte so flip the
 	// last bit
-	b.rawShareData[infoByteIndex] = b.rawShareData[infoByteIndex] ^ 0x01
+	b.rawShareData[infoByteIndex] ^= 0x01
 }
 
 func (b *Builder) prepareCompactShare() error {

shares/shares_test.go

@@ -16,19 +16,18 @@ func TestSequenceLen(t *testing.T) {
 		wantLen uint32
 		wantErr bool
 	}
-	sparseNamespaceID := bytes.Repeat([]byte{1}, namespace.NamespaceSize)
-	firstShare := append(sparseNamespaceID,
+	firstShare := append(bytes.Repeat([]byte{1}, namespace.NamespaceSize),
 		[]byte{
 			1,           // info byte
 			0, 0, 0, 10, // sequence len
 			1, 2, 3, 4, 5, 6, 7, 8, 9, 10, // data
 		}...)
-	firstShareWithLongSequence := append(sparseNamespaceID,
+	firstShareWithLongSequence := append(bytes.Repeat([]byte{1}, namespace.NamespaceSize),
 		[]byte{
 			1,           // info byte
 			0, 0, 1, 67, // sequence len
 		}...)
-	continuationShare := append(sparseNamespaceID,
+	continuationShare := append(bytes.Repeat([]byte{1}, namespace.NamespaceSize),
 		[]byte{
 			0, // info byte
 		}...)

square/square.go

@@ -250,7 +250,7 @@ func WriteSquare(
 	}
 
 	square := make([]shares.Share, totalShares)
-	copy(square[:], txShares)
+	copy(square, txShares)
 	copy(square[pfbStartIndex:], pfbShares)
 	if blobWriter.Count() > 0 {
 		copy(square[paddingStartIndex:], padding)

square/square_test.go

@@ -23,7 +23,8 @@ func TestSquareConstruction(t *testing.T) {
 	sendTxs := test.GenerateTxs(250, 250, 250)
 	pfbTxs := test.GenerateBlobTxs(10_000, 1, 1024)
 	t.Run("normal transactions after PFB transactions", func(t *testing.T) {
-		txs := append(sendTxs[:5], append(pfbTxs, sendTxs[5:]...)...)
+		txs := sendTxs[:5]
+		txs = append(txs, append(pfbTxs, txs...)...)
 		_, err := square.Construct(txs, defaultMaxSquareSize, defaultSubtreeRootThreshold)
 		require.Error(t, err)
 	})