test(v1.x): consistent appHash between commits #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ninabarbakadze
force-pushed
the
nina/backport-multi-validator-genesis
branch
from
7c25491
to
af9ecdf
Compare
ninabarbakadze
force-pushed
the
nina/non-determinism-test-v1.x
branch
from
d338f0f
to
a1262da
Compare
ninabarbakadze
changed the title
ninabarbakadze
requested review from
ramin,
staheri14,
cmwaters,
rootulp and
evan-forbes
and removed request for
a team,
ramin and
staheri14
rootulp
previously approved these changes
Jun 7, 2024
evan-forbes
previously approved these changes
Jun 7, 2024
ninabarbakadze
dismissed stale reviews from evan-forbes and rootulp
The base branch was changed.
ninabarbakadze
added a commit
that referenced
this pull request
Jun 10, 2024
## Overview Fixes #2414 ### This test is split up in a few parts: - Execute transactions deterministically on v1 and save the AppHash. #3522 ([includes genesis folder backport from utils](#3520)) - Set up the same testApp environment on main, execute transactions and assert that the AppHash matches the one from v1 ### Verifying the AppHash: If you want to make sure that the expected AppHash is correct, you can run the [non determinism test on v1.x](#3522) that generates it. ### Follow-ups: #3509 #3540 --------- Co-authored-by: Rootul P <[email protected]>
ninabarbakadze
force-pushed
the
nina/non-determinism-test-v1.x
branch
from
726552c
to
563ab6a
Compare
rootulp
approved these changes
Jun 20, 2024
cmwaters
approved these changes
Jun 21, 2024
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
## Overview Fixes #2414 ### This test is split up in a few parts: - Execute transactions deterministically on v1 and save the AppHash. celestiaorg/celestia-app#3522 ([includes genesis folder backport from utils](celestiaorg/celestia-app#3520)) - Set up the same testApp environment on main, execute transactions and assert that the AppHash matches the one from v1 ### Verifying the AppHash: If you want to make sure that the expected AppHash is correct, you can run the [non determinism test on v1.x](celestiaorg/celestia-app#3522) that generates it. ### Follow-ups: #3509 celestiaorg/celestia-app#3540 --------- Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds consistent appHash test on v1.x