Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds the ability to run txsim as knuu instance for testground sanity test #3244

Merged
merged 71 commits into from
Apr 5, 2024

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Apr 2, 2024

Closes #3189

Summary of changes:

  • Introduces the capability to customize the resource allocation for each Node and TxSimNode individually
  • Enables running txsim as a knuu instance.
  • Allows spinning up multiple instances of txsim (e.g., one or more per validator)
  • Enhanced logs

I have also tested all the e2e tests, and they pass successfully.

staheri14 and others added 30 commits March 26, 2024 13:19
test/e2e/testnet.go Outdated Show resolved Hide resolved
test/e2e/testnet.go Outdated Show resolved Hide resolved
test/e2e/testnet.go Outdated Show resolved Hide resolved
@staheri14
Copy link
Contributor Author

The go vulnerabilities should be resolved after bumping go version to Go 1.22.2 i.e., #3263

test/e2e/testnet.go Show resolved Hide resolved
test/e2e/testnet.go Show resolved Hide resolved
test/e2e/testnet.go Show resolved Hide resolved
test/e2e/testnet.go Show resolved Hide resolved
test/e2e/testnet.go Show resolved Hide resolved
cmwaters
cmwaters previously approved these changes Apr 5, 2024
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM with one blocking comment

test/e2e/throughput_test.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team April 5, 2024 15:32
This reverts commit 391bf08.
@staheri14
Copy link
Contributor Author

@coderabbitai pause

@staheri14 staheri14 enabled auto-merge (squash) April 5, 2024 16:44
@celestia-bot celestia-bot requested a review from a team April 5, 2024 18:26
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staheri14 staheri14 merged commit defff08 into main Apr 5, 2024
33 checks passed
@staheri14 staheri14 deleted the sanaz/testground-sanity-test branch April 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running txsim as a knuu instance inside e2e tests
4 participants