Nina/min gas price #3015
Closed
Nina/min gas price #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes celestiaorg#2901 ## Testing The previous commands still work b/c they are aliases: ``` $ ./build/celestia-appd tx blob pay-for-blob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob pay-for-blobs Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlob Error: pay-for-blob requires two arguments: namespaceID and blob $ ./build/celestia-appd tx blob PayForBlobs Error: pay-for-blob requires two arguments: namespaceID and blob ```
Closes celestiaorg#2990 ## Testing ```shell $ ./build/celestia-appd tx blob PayForBlob --help Pay for data blob(s) to be published to Celestia. To publish a single blob, specify the namespaceID and blob via CLI arguments. To publish multiple blobs, use the --input-file flag with the path to a JSON file. The JSON should look like: { "Blobs": [ { "namespaceID": "0x00010203040506070809", "blob": "0x48656c6c6f2c20576f726c6421" }, { "namespaceID": "0x00010203040506070809", "blob": "0x48656c6c6f2c20576f726c6421" } ] } The namespaceID is the user-specifiable portion of a version 0 namespace. The namespaceID must be a hex encoded string of 10 bytes. The blob must be a hex encoded string of non-zero length. Usage: celestia-appd tx blob PayForBlobs [namespaceID blob] [flags] ```
This PR using a `Ticker` for periodically call `GetTx` by given hash instead of a `Timer`. This makes the code clean and avoids calling reset `Timer` multiple times. It's similar to `WaitMined` in [geth](https://github.com/ethereum/go-ethereum/blob/09e0208029ff96a9cda0c69dbaebfd3f31a39771/accounts/abi/bind/util.go#L32). Other changes: * Add lock when get `pollTime` --------- Co-authored-by: Rootul Patel <[email protected]>
## Overview updates core to revert the breaking config change. we'll get the config change when we update comet to something other than that based on v0.34. backporting manually since this is guaranteed to have conflicts thanks to the change in go mod
…iaorg#2992) It's probably misleading that `GetSequence` should not only return the sequence number but increment it. The incrementing sequence should be internal and the user should just be able to use `Sequence` if they wish to query the sequence number of the signer
….10 (celestiaorg#3008) Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.13.9 to 1.13.10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ethereum/go-ethereum/releases">github.com/ethereum/go-ethereum's releases</a>.</em></p> <blockquote> <h2>Sharjila B (v1.13.10)</h2> <p><strong>This release is equivalent to v1.13.9, just contains a version bump. The reason is that a bad commit was tagged on 1.13.9 originally and whilst it was untagged and fixed, some caches (Go's package manager (<code>go mod</code>)) managed to store the temporary bad version. As there is no way for us to flush the bad version out, it's cleaner to tag a next version instead. Apologies about the mess.</strong></p> <hr /> <p>This release fixes a few issues and <strong>enables the Cancun upgrade for the Goerli network</strong> at block timestamp 1705473120 (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28719">#28719</a>) which is 6:32:am 17. Jan. 2024 UTC.</p> <p>:warning: <strong>If you are running Goerli, this is a required update!</strong></p> <p>Apart from the Goerli configuration update, we have a few other changes.</p> <ul> <li>The 'simulated backend' in package <code>accounts/abi/backends</code> was rewritten. The improved version is available from the new package <code>ethclient/simulated</code>. A backwards-compatibility wrapper remains in the old location. (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28202">#28202</a>)</li> <li>Fix ABI-encoding of negative big.Int in topics (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28764">#28764</a>)</li> <li>In JSON logging output, the "error" level is now correctly emitted as <code>"error"</code>. (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28774">#28774</a>, <a href="https://redirect.github.com/ethereum/go-ethereum/pull/28780">#28780</a>)</li> <li>Fixed an issue with configuration of stdlib package <code>log</code> for consumers of the geth library (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28747">#28747</a>)</li> <li><code>geth removedb</code> can now be run non-interactively (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28725">#28725</a>)</li> <li>We're building a package for ubuntu 23.10: mantic minotaur now (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28728">#28728</a>)</li> </ul> <h3>Testing</h3> <ul> <li>Add <code>currentExcessBlobGas</code> to the state tests for better coverage of state tests (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28735">#28735</a>)</li> <li>Fixed an issue in t8n regarding blob gas usage (<a href="https://redirect.github.com/ethereum/go-ethereum/pull/28734">#28735</a>)</li> </ul> <p>For a full rundown of the changes please consult the Geth 1.13.9 <a href="https://github.com/ethereum/go-ethereum/milestone/157?closed=1">release milestone</a>.</p> <hr /> <p>As with all our previous releases, you can find the:</p> <ul> <li>Pre-built binaries for all platforms on our <a href="https://geth.ethereum.org/downloads/">downloads page</a>.</li> <li>Docker images published under <a href="https://cloud.docker.com/u/ethereum/repository/docker/ethereum/client-go"><code>ethereum/client-go</code></a>.</li> <li>Ubuntu packages in our <a href="https://launchpad.net/~ethereum/+archive/ubuntu/ethereum">Launchpad PPA repository</a>.</li> <li>OSX packages in our <a href="https://github.com/ethereum/homebrew-ethereum">Homebrew Tap repository</a>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ethereum/go-ethereum/commit/bc0be1b1060b51b802b88a1a528d36021f21c324"><code>bc0be1b</code></a> Merge branch 'master' into release/1.13</li> <li><a href="https://github.com/ethereum/go-ethereum/commit/a162091e8f5e9bae019987ee9feab0249f1c22a5"><code>a162091</code></a> version: release v1.13.10 to fix bad tag</li> <li><a href="https://github.com/ethereum/go-ethereum/commit/daa2e5d6a66833b9834b60a3a46835610bbde99a"><code>daa2e5d</code></a> params: begin v1.13.10 release cycle</li> <li>See full diff in <a href="https://github.com/ethereum/go-ethereum/compare/v1.13.9...v1.13.10">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closes celestiaorg#736 Note: I played around with multisigs and wrote a script to show their basic functionality but that content seems more appropriate to live at https://docs.celestia.org/ than in the specs. Hence celestiaorg/docs#1351
## Overview Refactor tests to use app constants instead of hardcoded values ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist