docs: add column for governance modifiable params in resource_pricing #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahimahmedx
requested review from
liamsi,
adlerjohn,
evan-forbes,
rootulp and
cmwaters
as code owners
WalkthroughWalkthroughThe documentation for resource pricing has been updated to reflect an increase in the number of parameters that can be adjusted through governance for gas usage, rising from three to four. A new column has also been introduced in the resource pricing table to indicate which parameters can be modified via governance. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
evan-forbes
reviewed
Jan 2, 2024
evan-forbes
reviewed
Jan 2, 2024
evan-forbes
approved these changes
Jan 2, 2024
rootulp
reviewed
Jan 2, 2024
Oh good point. I wasn't sure if they could all be modified by governance but since @fahimahmedx confirmed they can all be modified, I'm okay with merging this PR as-is or removing the column and just updating the "fourth" thing |
rootulp
approved these changes
Jan 2, 2024
rootulp
pushed a commit
to rootulp/celestia-app
that referenced
this pull request
Jan 11, 2024
add auth, blob, blobstream, and consensus governance param tests add governance params tests for distribution add tests for modifying gov params add tests for modifying ibc params add tests for modifying slashing params add tests for modifying staking params ci: remove version_bump job (celestiaorg#2962) Closes celestiaorg#2884 - Remove the version_bump and branch_name jobs - Extract the goreleaser jobs to a new file Can still create a release. See https://github.com/rootulp/celestia-app/actions/runs/7324051789/job/19947265102 docs: add column for governance modifiable params in resource_pricing (celestiaorg#2974) Addresses celestiaorg#2966 by using the governance modifiable params tests in PR All four of the params are modifiable by governance, which matches the specs in [params.md](https://github.com/celestiaorg/celestia-app/blob/main/specs/src/specs/params.md). - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords chore: remove unnecessary conversions (celestiaorg#2975) Use linter to detect unnecessary type conversions https://github.com/mdempsky/unconvert ci: enable govulncheck (celestiaorg#2969) Closes celestiaorg#2968 Supersedes celestiaorg#2744 - CI workflow is inspired by https://github.com/celestiaorg/celestia-core/blob/main/.github/workflows/govulncheck.yml - Bumped to Go 1.21.5 to resolve some vulnerabilities identified by govulncheck improve naming of governance params test suite fix govHandler and remove test for an unmodifiable param. remove unneeded minter setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses #2966 by using the governance modifiable params tests in PR #2973.
All four of the params are modifiable by governance, which matches the specs in params.md.
Checklist