Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: prevent modifications on governance unmodifiable params #2919

Closed
wants to merge 21 commits into from
Closed

feat!: prevent modifications on governance unmodifiable params #2919

wants to merge 21 commits into from

Commits on Dec 9, 2023

  1. test: add governance unmodifiable params

    @fahimahmedx
    fahimahmedx committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    958d74f View commit details
    Browse the repository at this point in the history

  2. remove invalid param test

    @fahimahmedx
    fahimahmedx committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f966d2f View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. update BlockedParams

    @fahimahmedx
    fahimahmedx committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d8758b1 View commit details
    Browse the repository at this point in the history

  2. Revert "remove invalid param test" 

    This reverts commit f966d2f.
    @fahimahmedx
    fahimahmedx committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d4ea38b View commit details
    Browse the repository at this point in the history

  3. fix TestParamFilter

    @fahimahmedx
    fahimahmedx committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    9c2d8fc View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Add initial test cases for unmodifiable parameters

    @fahimahmedx
    fahimahmedx committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    634ab86 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. test modifying all remaining unmodifiable governance tests

    @fahimahmedx
    fahimahmedx committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    574392a View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. move location of tests and use app.go in test suite

    @fahimahmedx
    fahimahmedx committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    dbd315a View commit details
    Browse the repository at this point in the history

  2. update commenting

    @fahimahmedx
    fahimahmedx committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    610678d View commit details
    Browse the repository at this point in the history

  3. update App.BlockedParams()

    @fahimahmedx
    fahimahmedx committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    db5b4fb View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. update params.md docs to reference tests

    @fahimahmedx
    fahimahmedx committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    c874633 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. update paramter modification test in std_sdk_test.go

    @fahimahmedx
    fahimahmedx committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    c8cb845 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-governance-unmodifiable-tests

    @fahimahmedx
    fahimahmedx authored Dec 26, 2023
    Configuration menu
    Copy the full SHA
    5dd452c View commit details
    Browse the repository at this point in the history

  3. remove commented out test

    @fahimahmedx
    fahimahmedx committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    3f964c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. fix params.md links

    @fahimahmedx
    fahimahmedx committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    f953792 View commit details
    Browse the repository at this point in the history

  2. Add in test for consensus.block.TimeIotaMs

    @fahimahmedx
    fahimahmedx committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    39fede8 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. improve naming in governance params test

    @fahimahmedx
    fahimahmedx committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    00a5bb4 View commit details
    Browse the repository at this point in the history

  2. fix naming and add comment

    @fahimahmedx
    fahimahmedx committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    0ee81b0 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary expErr bool

    @fahimahmedx
    fahimahmedx committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    3738a99 View commit details
    Browse the repository at this point in the history

  4. improve readability of TestUnmodifiableParameters

    @fahimahmedx
    fahimahmedx committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    f3bc57e View commit details
    Browse the repository at this point in the history

  5. change conensus to consensus

    @fahimahmedx
    fahimahmedx committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5958cb4 View commit details
    Browse the repository at this point in the history