Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minumum signatures in the block. #2469

Closed
rootulp opened this issue Sep 11, 2023 · 1 comment · Fixed by #2417
Closed

Minumum signatures in the block. #2469

rootulp opened this issue Sep 11, 2023 · 1 comment · Fixed by #2417
Assignees
@evan-forbes
Labels
documentation Improvements or additions to documentation specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 11, 2023 •
edited
Loading

Minumum signatures in the block.

The description here should be changed to sth more descriptive: Minumum number of blocks signed in the SignedBlocksWindow. Or sth like that?

Originally posted by @liamsi in #2416 (comment)
@rootulp rootulp self-assigned this Sep 11, 2023
@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs labels Sep 11, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 11, 2023
This was referenced Sep 11, 2023
Closed
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2023

The value is also incorrect. It should be .5 or 50%

Ref: https://github.com/cosmos/cosmos-sdk/blob/d6d929843bbd331b885467475bcb3050788e30ca/x/slashing/types/params.go#L18

@evan-forbes evan-forbes linked a pull request Sep 13, 2023 that will close this issue
chore: update more default parameters #2417
Merged
5 tasks
@rootulp rootulp assigned evan-forbes and unassigned rootulp Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
2 participants
@rootulp @evan-forbes