Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cip-4 to 30 days + 1 hour worth of seconds (2595600 seconds), move to Final #72

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Feb 6, 2024

Overview

This changes instances of "30 days" to "30 days + 1 hour worth of seconds (2595600 seconds)".

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from ramin February 6, 2024 17:59
@jcstein jcstein requested review from renaynay and removed request for ebuchman and YazzyYaz February 6, 2024 18:02
@@ -1,7 +1,7 @@
---
cip: 4
title: Standardize data expiry time for pruned nodes
description: Standardize default data expiry time for pruned nodes to 30 days.
description: Standardize default data expiry time for pruned nodes to 30 days + 1 hour worth of seconds (2595600 seconds).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renaynay I believe that some of these instances will revert back to just "30 days"

@jcstein jcstein changed the title feat: update cip-4 to 30 days + 1 hour worth of seconds (2595600 seconds) feat: update cip-4 to 30 days + 1 hour worth of seconds (2595600 seconds), move to last call Feb 6, 2024
@jcstein jcstein changed the title feat: update cip-4 to 30 days + 1 hour worth of seconds (2595600 seconds), move to last call feat: update cip-4 to 30 days + 1 hour worth of seconds (2595600 seconds), move to Final Feb 6, 2024
@YazzyYaz YazzyYaz merged commit 149fcbc into main Feb 6, 2024
1 check passed
@YazzyYaz YazzyYaz deleted the jcs/update-cip-4 branch February 6, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants