Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: rename auto-request-review.yml to auto_request_review.yml #63

Merged
merged 1 commit into from
Feb 1, 2024
Merged

bug: rename auto-request-review.yml to auto_request_review.yml #63

merged 1 commit into from
Feb 1, 2024

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Feb 1, 2024

Overview

The use of - vs _ in the name was missed on the original PR. Updating to fix the error of not seeing the config file.

@MSevey MSevey requested a review from jcstein February 1, 2024 15:58
rootulp
rootulp approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the default is auto_request_review.yml

Ref: https://github.com/necojackarc/auto-request-review/blob/d79257da48ade29bb20ff86bbd90fd3432e88255/README.md?plain=1#L184

@MSevey
Copy link
Member Author

MSevey commented Feb 1, 2024

Looks like the default is auto_request_review.yml

Ref: https://github.com/necojackarc/auto-request-review/blob/d79257da48ade29bb20ff86bbd90fd3432e88255/README.md?plain=1#L184

correct, thanks for linking the docs 👍

jcstein
jcstein approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSevey and @rootulp! LGTM

@jcstein jcstein merged commit c934d87 into main Feb 1, 2024
4 checks passed
@jcstein jcstein deleted the bug-rename-auto-review-file-to-standard-naming branch February 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcstein jcstein jcstein approved these changes

@rootulp rootulp rootulp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSevey @rootulp @jcstein