Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gov modifiable params #43

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: gov modifiable params #43

merged 1 commit into from
Jan 19, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jan 18, 2024

CIP-13 contains two parameters that are incorrectly marked as False for the governance modifiable column. This PR corrects the error.

For more context, see:

  1. Parameters that are stated as not governance modifiable, are actually governance modifiable. celestia-app#2972
  2. Increase test coverage for governance modifiable and governance unmodifiable params celestia-app#2916

@rootulp rootulp marked this pull request as draft January 18, 2024 20:19
@rootulp rootulp marked this pull request as ready for review January 18, 2024 21:45
@YazzyYaz YazzyYaz merged commit 8b1f707 into celestiaorg:main Jan 19, 2024
1 check passed
@rootulp rootulp deleted the rp/update-cip13 branch January 19, 2024 19:05
@rootulp rootulp mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazzyYaz YazzyYaz YazzyYaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rootulp @YazzyYaz