Safer listener in ResourceItemFragment

celestiamobile · Jul 25, 2023 · d4350d5 · d4350d5
1 parent 79680f4
commit d4350d5
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/src/main/java/space/celestia/mobilecelestia/resource/ResourceItemFragment.kt b/app/src/main/java/space/celestia/mobilecelestia/resource/ResourceItemFragment.kt
@@ -75,7 +75,6 @@ class ResourceItemFragment : NavigationFragment.SubFragment(), ResourceManager.L
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
-        resourceManager.addListener(this)
         if (savedInstanceState != null) {
             item = savedInstanceState.getSerializableValue(ARG_ITEM, ResourceItem::class.java)!!
             lastUpdateDate = savedInstanceState.getSerializableValue(ARG_UPDATED_DATE, Date::class.java)!!
@@ -115,6 +114,8 @@ class ResourceItemFragment : NavigationFragment.SubFragment(), ResourceManager.L
 
         updateUI()
 
+        resourceManager.addListener(this)
+
         return view
     }
 
@@ -170,10 +171,10 @@ class ResourceItemFragment : NavigationFragment.SubFragment(), ResourceManager.L
         listener = null
     }
 
-    override fun onDestroy() {
+    override fun onDestroyView() {
         resourceManager.removeListener(this)
 
-        super.onDestroy()
+        super.onDestroyView()
     }
 
     override fun menuItemClicked(groupId: Int, id: Int): Boolean {