Skip to content

Commit

Permalink
Fix destination fragment padding
Browse files Browse the repository at this point in the history
  • Loading branch information
levinli303 committed Dec 18, 2022
1 parent 06b5a49 commit bddd237
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:installLocation="auto"
android:versionCode="304"
android:versionCode="305"
android:versionName="1.5.14">

<uses-feature android:glEsVersion="0x00020000" android:required="true" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ class InfoFragment : NavigationFragment.SubFragment() {
const val ARG_OBJECT_POINTER = "object"
const val ARG_OBJECT_TYPE = "type"
const val ARG_EMBEDDED_IN_NAVIGATION = "embedded-in-navigation"
const val ARG_HAS_BOTTOM_BAR = "has-bottom-bar"

@JvmStatic
fun newInstance(selection: Selection, embeddedInNavigation: Boolean = false) =
Expand Down
8 changes: 5 additions & 3 deletions app/src/main/res/layout/fragment_destination_detail.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
android:paddingHorizontal="@dimen/common_page_medium_margin_horizontal"
android:paddingVertical="@dimen/common_page_medium_margin_vertical">
android:paddingHorizontal="@dimen/common_page_medium_margin_horizontal">
<androidx.core.widget.NestedScrollView
android:layout_weight="1"
android:layout_width="match_parent"
android:clipToPadding="false"
android:paddingTop="@dimen/common_page_medium_margin_vertical"
android:layout_height="0dp">
<LinearLayout
android:orientation="vertical"
Expand Down Expand Up @@ -52,6 +53,7 @@
android:id="@+id/action_button"
style="@style/Button"
android:layout_width="match_parent"
android:layout_height="wrap_content"/>
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/common_page_medium_margin_vertical"/>
</LinearLayout>
</FrameLayout>

0 comments on commit bddd237

Please sign in to comment.