Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable buggy skipping of duplicate runs #148

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Sep 26, 2022

Due to a bug, the fkirc/skip-duplicate-actions incorrectly identifies pull_request as duplicates to push triggers based on identical base branches, even though pull requests run will on an implicit merge commit.

This temporarily disables skipping of concurrent runs. We keep cancellation of known-outdated runs when a newer commit was pushed on the same branch.

@fknorr fknorr requested a review from psalz September 26, 2022 09:47
@fknorr fknorr self-assigned this Sep 26, 2022
Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not looking at this earlier, LGTM

@fknorr fknorr merged commit 59e7d61 into master Oct 11, 2022
@fknorr fknorr deleted the disable-skip-ci branch October 11, 2022 11:52
dentarg added a commit to dentarg/puma that referenced this pull request Jun 5, 2024
From https://github.com/fkirc/skip-duplicate-actions?tab=readme-ov-file#concurrent_skipping

> Skip a workflow run if the same workflow is already running

but it does not seem reliable, for example, this workflow run
https://github.com/puma/puma/actions/runs/9386209788
looks 100% green but that is because everything was skipped

https://github.com/fkirc/skip-duplicate-actions/issues has many reports
about problems with `concurrent_skipping`

celerity/celerity-runtime#148 is an example of
another project disabling it.

[ci skip]
dentarg added a commit to puma/puma that referenced this pull request Jun 5, 2024
From https://github.com/fkirc/skip-duplicate-actions?tab=readme-ov-file#concurrent_skipping

> Skip a workflow run if the same workflow is already running

but it does not seem reliable, for example, this workflow run
https://github.com/puma/puma/actions/runs/9386209788
looks 100% green but that is because everything was skipped

https://github.com/fkirc/skip-duplicate-actions/issues has many reports
about problems with `concurrent_skipping`

celerity/celerity-runtime#148 is an example of
another project disabling it.

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants