Core - Xml Doc improvements/fixes

CefSharp.Core.Runtime/PostData.h

@@ -88,7 +88,7 @@ namespace CefSharp
 
         public:
             /// <summary>
-            /// Default constructor.
+            /// Initializes a new instance of the PostData class.
             /// </summary>
             PostData()
             {

CefSharp.Core.Runtime/RequestContextSettings.h

@@ -28,7 +28,7 @@ namespace CefSharp
 
         public:
             /// <summary>
-            /// Default constructor
+            /// Initializes a new instance of the RequestContextSettings class.
             /// </summary>
             RequestContextSettings() : _settings(new CefRequestContextSettings())
             {

CefSharp/Callback/TaskCompletionCallback.cs

@@ -18,7 +18,7 @@ public class TaskCompletionCallback : ICompletionCallback
         private bool onComplete; //Only ever accessed on the same CEF thread, so no need for thread safety
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskCompletionCallback class.
         /// </summary>
         public TaskCompletionCallback()
         {

CefSharp/Callback/TaskDeleteCookiesCallback.cs

@@ -23,7 +23,7 @@ public class TaskDeleteCookiesCallback : IDeleteCookiesCallback
         private bool onComplete; //Only ever accessed on the same CEF thread, so no need for thread safety
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskDeleteCookiesCallback class.
         /// </summary>
         public TaskDeleteCookiesCallback()
         {

CefSharp/Callback/TaskRegisterCdmCallback.cs

@@ -18,7 +18,7 @@ public class TaskRegisterCdmCallback : IRegisterCdmCallback
         private bool onComplete; //Only ever accessed on the same CEF thread, so no need for thread safety
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskRegisterCdmCallback class.
         /// </summary>
         public TaskRegisterCdmCallback()
         {

CefSharp/Callback/TaskResolveCallback.cs

@@ -19,7 +19,7 @@ public class TaskResolveCallback : IResolveCallback
         private bool onComplete; //Only ever accessed on the same CEF thread, so no need for thread safety
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskResolveCallback class.
         /// </summary>
         public TaskResolveCallback()
         {

CefSharp/Callback/TaskSetCookieCallback.cs

@@ -18,7 +18,7 @@ public class TaskSetCookieCallback : ISetCookieCallback
         private bool onComplete; //Only ever accessed on the same CEF thread, so no need for thread safety
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskSetCookieCallback class.
         /// </summary>
         public TaskSetCookieCallback()
         {

CefSharp/CefLibraryHandle.cs

@@ -33,7 +33,7 @@ private enum LoadLibraryFlags : uint
         }
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the CefLibraryHandle class.
         /// </summary>
         /// <param name="path">libcef.dll full path.</param>
         public CefLibraryHandle(string path) : base(IntPtr.Zero, true)

CefSharp/DevTools/Headers.cs

@@ -19,6 +19,9 @@ namespace CefSharp.DevTools.Network
     /// Helper methods for dealing with comma separated header values based on https://github.com/dotnet/aspnetcore/blob/52eff90fbcfca39b7eb58baad597df6a99a542b0/src/Http/Http.Abstractions/src/Extensions/HeaderDictionaryExtensions.cs
     public class Headers : Dictionary<string, string>
     {
+        /// <summary>
+        /// Initializes a new instance of the Headers class.
+        /// </summary>
         public Headers() : base(StringComparer.OrdinalIgnoreCase)
         {
         }

CefSharp/Handler/ContextMenuHandler.cs

@@ -4,6 +4,7 @@
 
 namespace CefSharp.Handler
 {
+    /// <summary>
     /// Inherit from this class to handle context menu events. 
     /// </summary>
     public class ContextMenuHandler : IContextMenuHandler

CefSharp/IResponse.cs

@@ -57,8 +57,7 @@ public interface IResponse : IDisposable
         string GetHeaderByName(string name);
 
         /// <summary>
-        /// Set the header name to value. The Referer value cannot be set using this method.
-        /// Use <see cref="SetReferrer(string, ReferrerPolicy)"/> instead.
+        /// Set the header name to value.
         /// </summary>
         /// <param name="name">header name</param>
         /// <param name="value">new header value</param>

CefSharp/IWebBrowser.cs

@@ -92,7 +92,7 @@ public interface IWebBrowser : IDisposable
         /// <param name="url">url to load</param>
         /// <param name="ctx">SynchronizationContext to execute the continuation on, if null then the ThreadPool will be used.</param>
         /// <returns>
-        /// A <see cref="Task{int}"/> that can be awaited to load the <paramref name="url"/> and return the HttpStatusCode and <see cref="CefErrorCode"/>.
+        /// A <see cref="Task{LoadUrlAsyncResponse}"/> that can be awaited to load the <paramref name="url"/> and return the HttpStatusCode and <see cref="CefErrorCode"/>.
         /// A HttpStatusCode equal to 200 and <see cref="CefErrorCode.None"/> is considered a success.
         /// </returns>
         Task<LoadUrlAsyncResponse> LoadUrlAsync(string url = null, SynchronizationContext ctx = null);

CefSharp/Internals/ParentProcessMonitor.cs

@@ -18,7 +18,7 @@ public static class ParentProcessMonitor
     {
         /// <summary>
         /// Starts a long running task (spawns new thread) used to monitor the parent process
-        /// and calls <see cref="Process.Kill"/> if the parent exits unexpectedly (usually result of a crash).
+        /// and calls <see cref="Process.Kill()"/> if the parent exits unexpectedly (usually result of a crash).
         /// </summary>
         /// <param name="parentProcessId">process Id of the parent application</param>
         public static void StartMonitorTask(int parentProcessId)

CefSharp/Internals/TaskExtensions.cs

@@ -111,7 +111,7 @@ public static void TrySetResultAsync<TResult>(this TaskCompletionSource<TResult>
         /// </summary>
         /// <typeparam name="TResult">Generic param</typeparam>
         /// <param name="taskCompletionSource">tcs</param>
-        /// <param name="result">result</param>
+        /// <param name="ex">exception</param>
         public static void TrySetExceptionAsync<TResult>(this TaskCompletionSource<TResult> taskCompletionSource, Exception ex)
         {
             Task.Factory.StartNew(delegate

CefSharp/JavascriptBinding/CamelCaseJavascriptNameConverter.cs

@@ -39,7 +39,7 @@ string IJavascriptNameConverter.ConvertReturnedObjectPropertyAndFieldToNameJavas
         /// only the bound methods/fields/properties were converted. Objects returned
         /// from a method call were not translated. To preserve this functionality
         /// for upgrading users we split this into two methods. Typically thie method
-        /// would return the same result as <see cref="ConvertToJavascript(string)"/>
+        /// would return the same result as <see cref="ConvertToJavascript(MemberInfo)"/>
         /// Issue #2442
         /// </summary>
         /// <param name="memberInfo">property/field/method</param>

CefSharp/JavascriptBinding/IJavascriptNameConverter.cs

@@ -25,7 +25,7 @@ public interface IJavascriptNameConverter
         /// only the bound methods/fields/properties were converted. Objects returned
         /// from a method call were not translated. To preserve this functionality
         /// for upgrading users we split this into two methods. Typically thie method
-        /// would return the same result as <see cref="ConvertToJavascript(string)"/>
+        /// would return the same result as <see cref="ConvertToJavascript(MemberInfo)"/>
         /// Issue #2442
         /// </summary>
         /// <param name="memberInfo">property/field/method</param>

CefSharp/LoadUrlAsyncResponse.cs

@@ -32,7 +32,7 @@ public bool Success
         }
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the LoadUrlAsyncResponse class.
         /// </summary>
         /// <param name="errorCode">CEF Error Code</param>
         /// <param name="httpStatusCode">Http Status Code</param>

CefSharp/ModelBinding/DefaultBinder.cs

@@ -21,6 +21,10 @@ public class DefaultBinder : IBinder
         private static readonly MethodInfo ToArrayMethodInfo = typeof(Enumerable).GetMethod("ToArray", BindingFlags.Public | BindingFlags.Static);
         private readonly IJavascriptNameConverter javascriptNameConverter;
 
+        /// <summary>
+        /// Javascript Binder 
+        /// </summary>
+        /// <param name="javascriptNameConverter">name converter</param>
         public DefaultBinder(IJavascriptNameConverter javascriptNameConverter = null)
         {
             this.javascriptNameConverter = javascriptNameConverter;

CefSharp/Preferences/SetPreferenceResponse.cs

@@ -21,7 +21,7 @@ public class SetPreferenceResponse
         public string ErrorMessage { get; private set; }
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the SetPreferenceResponse class.
         /// </summary>
         /// <param name="success">success</param>
         /// <param name="errorMessage">error message</param>

CefSharp/Preferences/SetProxyResponse.cs

@@ -5,13 +5,13 @@
 namespace CefSharp.Preferences
 {
     /// <summary>
-    /// Response when <see cref="RequestContextExtensions.SetProxyAsync(IRequestContext, string, string, int?, out string)"/>
-    /// is called.
+    /// Response when either <see cref="RequestContextExtensions.SetProxyAsync(IRequestContext, string, int?)"/>
+    /// or <see cref="RequestContextExtensions.SetProxyAsync(IRequestContext, string, string, int?)"/> are called.
     /// </summary>
     public class SetProxyResponse : SetPreferenceResponse
     {
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the SetProxyResponse class.
         /// </summary>
         /// <param name="success">success</param>
         /// <param name="errorMessage">error message</param>

CefSharp/RenderProcess/IV8Context.cs

@@ -4,6 +4,15 @@
 
 namespace CefSharp.RenderProcess
 {
+    /// <summary>
+    /// V8 context handle.
+    /// V8 handles can only be accessed from the thread on which they are created.
+    /// Valid threads for creating a V8 handle include the render process main thread (TID_RENDERER) and WebWorker threads.
+    /// A task runner for posting tasks on the associated thread can be retrieved via the CefV8Context::GetTaskRunner() method.
+    /// </summary>
+    /// <remarks>
+    /// V8 is Google’s open source high-performance JavaScript and WebAssembly engine.
+    /// </remarks>
     public interface IV8Context
     {
         /// <summary>

CefSharp/RenderProcess/V8Exception.cs

@@ -7,6 +7,9 @@ namespace CefSharp.RenderProcess
     /// <summary>
     /// Class representing a V8 exception.
     /// </summary>
+    /// <remarks>
+    /// V8 is Google’s open source high-performance JavaScript and WebAssembly engine.
+    /// </remarks>
     public class V8Exception
     {
         /// <summary>
@@ -57,6 +60,17 @@ public class V8Exception
         /// <returns>Returns the index within the script of the first character where the error occurred.</returns>
         public int StartPosition { get; private set; }
 
+        /// <summary>
+        /// V8 Exception
+        /// </summary>
+        /// <param name="endColumn">index within the line of the last character where the error occurred.</param>
+        /// <param name="endPosition">index within the script of the last character where the error occurred.</param>
+        /// <param name="lineNumber">1-based number of the line where the error occurred or 0 if the line number is unknown.</param>
+        /// <param name="message">exception message.</param>
+        /// <param name="scriptResourceName">resource name for the script from where the function causing the error originates.</param>
+        /// <param name="sourceLine">line of source code that the exception occurred within.</param>
+        /// <param name="startColumn">index within the line of the first character where the error occurred.</param>
+        /// <param name="startPosition">index within the script of the first character where the error occurred.</param>
         public V8Exception(int endColumn,
             int endPosition,
             int lineNumber,

CefSharp/RequestContextExtensions.cs

@@ -69,7 +69,6 @@ public static void LoadExtensionsFromDirectory(this IRequestContext requestConte
         /// <param name="requestContext">request context</param>
         /// <param name="name">preference key</param>
         /// <param name="value">preference value</param>
-        /// <param name="error">out error</param>
         /// <returns>returns <see cref="SetPreferenceResponse.Success"/> true if successfull, false otherwise.</returns>
         /// <remarks>Use Cef.UIThreadTaskFactory to execute this method if required,
         /// <see cref="IBrowserProcessHandler.OnContextInitialized"/> and ChromiumWebBrowser.IsBrowserInitializedChanged are both

CefSharp/SchemeHandler/OwinResourceHandler.cs

@@ -34,6 +34,10 @@ public class OwinResourceHandler : ResourceHandler
 
         private readonly AppFunc appFunc;
 
+        /// <summary>
+        /// OwinResourceHandler
+        /// </summary>
+        /// <param name="appFunc">Owin pipeline func</param>
         public OwinResourceHandler(AppFunc appFunc)
         {
             this.appFunc = appFunc;

CefSharp/SchemeHandler/OwinSchemeHandlerFactory.cs

@@ -19,11 +19,16 @@ public class OwinSchemeHandlerFactory : ISchemeHandlerFactory
     {
         private readonly AppFunc appFunc;
 
+        /// <summary>
+        /// OwinSchemeHandlerFactory
+        /// </summary>
+        /// <param name="appFunc">Owin pipeline func</param>
         public OwinSchemeHandlerFactory(AppFunc appFunc)
         {
             this.appFunc = appFunc;
         }
 
+        /// <inheritdoc/>
         public IResourceHandler Create(IBrowser browser, IFrame frame, string schemeName, IRequest request)
         {
             return new OwinResourceHandler(appFunc);

CefSharp/Visitor/TaskCookieVisitor.cs

@@ -19,14 +19,15 @@ public class TaskCookieVisitor : ICookieVisitor
         private List<Cookie> list;
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskCookieVisitor class.
         /// </summary>
         public TaskCookieVisitor()
         {
             taskCompletionSource = new TaskCompletionSource<List<Cookie>>();
             list = new List<Cookie>();
         }
 
+        /// <inheritdoc/>
         bool ICookieVisitor.Visit(Cookie cookie, int count, int total, ref bool deleteCookie)
         {
             list.Add(cookie);
@@ -40,6 +41,7 @@ bool ICookieVisitor.Visit(Cookie cookie, int count, int total, ref bool deleteCo
             return true;
         }
 
+        /// <inheritdoc/>
         void IDisposable.Dispose()
         {
             if (list != null && list.Count == 0)

CefSharp/Visitor/TaskNavigationEntryVisitor.cs

@@ -10,30 +10,32 @@
 namespace CefSharp
 {
     /// <summary>
-    /// A <see cref="INavigationEntryVisitor"/> that uses a TaskCompletionSource
-    /// to simplify things
+    /// A <see cref="INavigationEntryVisitor"/> implementation that uses a <see cref="TaskCompletionSource{TResult}"/>
+    /// that allows you to call await/ContinueWith to get the list of NavigationEntries
     /// </summary>
     public class TaskNavigationEntryVisitor : INavigationEntryVisitor
     {
         private TaskCompletionSource<List<NavigationEntry>> taskCompletionSource;
         private List<NavigationEntry> list;
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskNavigationEntryVisitor class.
         /// </summary>
         public TaskNavigationEntryVisitor()
         {
             taskCompletionSource = new TaskCompletionSource<List<NavigationEntry>>();
             list = new List<NavigationEntry>();
         }
 
+        /// <inheritdoc/>
         bool INavigationEntryVisitor.Visit(NavigationEntry entry, bool current, int index, int total)
         {
             list.Add(entry);
 
             return true;
         }
 
+        /// <inheritdoc/>
         void IDisposable.Dispose()
         {
             if (list != null)

CefSharp/Visitor/TaskStringVisitor.cs

@@ -9,15 +9,15 @@
 namespace CefSharp
 {
     /// <summary>
-    /// A <see cref="IStringVisitor"/> that uses a TaskCompletionSource
-    /// to simplify things
+    /// A <see cref="IStringVisitor"/> that uses a <see cref="TaskCompletionSource{TResult}"/>
+    /// that allows you to call await/ContinueWith to get the result string.
     /// </summary>
     public class TaskStringVisitor : IStringVisitor
     {
         private readonly TaskCompletionSource<string> taskCompletionSource;
 
         /// <summary>
-        /// Default constructor
+        /// Initializes a new instance of the TaskStringVisitor class.
         /// </summary>
         public TaskStringVisitor()
         {

CefSharp/Web/JsonString.cs

@@ -15,6 +15,9 @@ namespace CefSharp.Web
     /// </summary>
     public class JsonString
     {
+        /// <summary>
+        /// JSON String
+        /// </summary>
         public string Json { get; private set; }
 
         /// <summary>
@@ -31,6 +34,7 @@ public JsonString(string json)
             Json = json;
         }
 
+        /// <inheritdoc/>
         public override string ToString()
         {
             return Json;