Bugfix / Argentinian transformRule mismatch $2 15-$3-$4 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port the rules that does not start with 1. ex: $2 15-$3-$4
|
Thanks. Please add a test that was failing before and works with the PR |
… start with \$1. example: (\$2 15-\$3-\$4)(AR), Argentina
I added the test, please have a look and give it a try. |
cedvdb
reviewed
Nov 9, 2024
test/phone_number_test.dart
Outdated
| group( | ||
| 'format national phone number if transformRule does not start with \$1. example: (\$2 15-\$3-\$4)(AR)', | ||
| () { | ||
| test('should return the formated phone number not the transformRule string', |
There was a problem hiding this comment.
Thanks for the test, can you rename
should return the formated phone number not the transformRule string
to
=> should format argentinian phone numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I found a bug while using phone_form_field: ^9.1.0 while trying to input an Argentinian phone number:
I've got the same result with running phone_numbers_parser locally:
I have also checked libphonenumber and it seems to woks fine:
The thing is that the transformRule starts with $2 (ex: $2 15-$3-$4) that will stop the loop and return the string without formatting it properly. I removed the contain index check of the transform rule in order to support the rules that does not start necessarily with 1, and it seems to work fine. If there is a better solution for this problem let me know an i can look into it and update the pr, thanks. Cheers!