-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the document cloud example #181
Conversation
Signed-off-by: Shaobo He <[email protected]>
@khieta @aaronjeline I'll update the entity JSON file and request JSON files if the policies/schema look good to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but overall the edits seem fine to me. Will delay approval until the README and entity/request JSON files are updated.
Co-authored-by: Kesha Hietala <[email protected]>
Co-authored-by: Kesha Hietala <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
Signed-off-by: Shaobo He <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just left some small comments.
Co-authored-by: Kesha Hietala <[email protected]>
Closed for now unless there are new interests. |
Issue #, if available:
Description of changes:
This PR simplifies the original model as follows.
is_authenticated
attribute from context. Now we assume each user is authenticated before requesting authorization.Public
entity type. I think it should amount to unconstrained principal.DocumentShare
entity type. It appears to me thatGroup
is all we need, provided that we remove thePublic
type.isPrivate
attribute. My rationale is that it can conflict with thepublic_access
attribute.