Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the document cloud example #181

Closed
wants to merge 9 commits into from

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Jul 30, 2024

Issue #, if available:

Description of changes:
This PR simplifies the original model as follows.

  1. Remove is_authenticated attribute from context. Now we assume each user is authenticated before requesting authorization.
  2. Remove Public entity type. I think it should amount to unconstrained principal.
  3. Remove DocumentShare entity type. It appears to me that Group is all we need, provided that we remove the Public type.
  4. Remove isPrivate attribute. My rationale is that it can conflict with the public_access attribute.
  5. Merge certain policies into a single policy.
  6. Remove two forbid policies using stale attributes.
  7. Revise the remaining policy such that only resource owner's blocked list takes effects.

Signed-off-by: Shaobo He <[email protected]>
@shaobo-he-aws
Copy link
Contributor Author

@khieta @aaronjeline I'll update the entity JSON file and request JSON files if the policies/schema look good to you.

Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, but overall the edits seem fine to me. Will delay approval until the README and entity/request JSON files are updated.

cedar-example-use-cases/document_cloud/policies.cedar Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/policies.cedar Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/policies.cedar Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/policies.cedar Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/policies.cedar Outdated Show resolved Hide resolved
shaobo-he-aws and others added 7 commits August 1, 2024 10:07
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left some small comments.

cedar-example-use-cases/document_cloud/README.md Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/README.md Outdated Show resolved Hide resolved
cedar-example-use-cases/document_cloud/README.md Outdated Show resolved Hide resolved
@shaobo-he-aws
Copy link
Contributor Author

Closed for now unless there are new interests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants