Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatically pick up html files within source directory within the webpack config. #167

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

Oatelaus
Copy link

@Oatelaus Oatelaus commented Oct 9, 2018

The purpose of this pull request is to address #114.

This will remove the requirement to add an entry for each HTML page implemented.

This PR adds an developer dependency of node-glob.

This still has the down fall that new files added whilst webpack is running aren't picked up and considered within livereloading.

@abhijithvijayan
Copy link
Member

Thank you for getting back to us @Fedelaus

@Oatelaus
Copy link
Author

Oatelaus commented Oct 9, 2018

I did a test with this and it compiles fine.

Can be viewed @ https://fedelaus.github.io/cea.ac.in/. (read below)

The project is a little difficult to test locally as the build processes seem to assume the environment is GH pages and at that this specific repositories GH-pages. So on my local copy, certain links don't work and on github pages some pages don't have the correct links to js files.

Am I missing something, or do you guys have the same issues as above when running the project locally?

@Oatelaus
Copy link
Author

Oatelaus commented Oct 9, 2018

@abhijithvijayan not a problem. Thanks for allowing me to contribute.

@ashikmeerankutty
Copy link
Member

@Fedelaus Thank you for your contribution.
@abhijithvijayan We can merge this PR after all the issues regarding creating file is complete.

@abhijithvijayan
Copy link
Member

@Fedelaus Thank you for your contribution.
@abhijithvijayan We can merge this PR after all the issues regarding creating file is complete.

That way we can remove entries in webpack.config.js

@abhijithvijayan abhijithvijayan merged commit 8e6239c into ceadoor:master Oct 10, 2018
@abhijithvijayan
Copy link
Member

I did a test with this and it compiles fine.

Can be viewed @ https://fedelaus.github.io/cea.ac.in/. (read below)

The project is a little difficult to test locally as the build processes seem to assume the environment is GH pages and at that this specific repositories GH-pages. So on my local copy, certain links don't work and on github pages some pages don't have the correct links to js files.

Am I missing something, or do you guys have the same issues as above when running the project locally?

@Fedelaus To you doubts, we can confirm that we also have issues with the links while running locally.
We had to change the links to /cea.ac.in/Link1 so that it works correctly on GH-Pages
and also we have to append .html to links while testing locally to load the page.
After the project is complete we'll shift this project to another main server after fixing the nav links to point from /

And the issue with your live gh pages version is that, the links to css and js files are being fetched from https://ceadoor.github.io/cea.ac.in/css/main.HASHVALUE.css and so the hashvalues differ and styling won't be applied.

For now we don't have a workaround as everything works on the ceadoor github pages

Feel free to suggest the work around if you find a fix for the links.

Thank you.

@abhijithvijayan
Copy link
Member

@Fedelaus You can create a new issue about the topic here

@Oatelaus
Copy link
Author

Created an issue regarding the above #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants