Test Pull Request #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fr_FR app translation for 3.9.0
Update translation_zh_CN.ts
Some more "directory server" discovered in French translation
* Update es_ES app translation for 3.9.0 * Fix errors * Fix conflict * Update translation
…endency #2720 Add libQt5Multimedia5 dependency to deb control (Forced merge)
PR #2535 introduced rate limiting for gain change messages. The logic required storing the previously used gain value per channel. This logic had some flaws: 1. The previously used gain value defaulted to 0, despite the server-side view of the channel being set to 1 (as the default). Therefore, gain(0) changes during a series of gain changes would be lost. The most common scenario would be the initial connection, which always triggers the rate limit and therefore the faulty logic. This also affected New Client Level = 0. 2. The previously used gain values were not reset upon changing servers. This might have caused losing arbitrary gain change messages, e.g. stored fader values. 3. The previously used gain values were not reset upon a channel disconnect. This might have caused missing fader level restores. This commit introduces a gain level memory reset to 1 (100%) on connect as well as on channel disconnects to fix these issues. Fixes: #2730 Co-authored-by: ann0see <[email protected]>
Client: Avoid losing gain changes
Fixed typo, capitalization, missed space and missed translation.
Fixed more typos, capitalization and missed space.
Translations: Add Korean to language selection
Missed translation and some pt_PT spelling
Fixed the translation for #2710 that got messed up during the branching/fetch/merge. This is the last one for pt_BR
Update sk_SK app translation for 3.9.0
Update pt_BR app translation for r3.9.0
…constructor Code: Make copy constructor/assignments explicit
JSON-RPC: Add option to specify bind address for server
IPv6 was tested successfully by @ann0see in #2917 (comment)
References: #2917 (comment) Co-authored-by: Peter L Jones <[email protected]>
JSON-RPC: Remove IPv6-untested warning from --jsonrpcbindip docs / improve empty address warning
When connecting to host names without port (e.g. example.org), the client will now perform an SRV lookup to _jamulus._udp.example.org. If this lookup returns exactly one result, the result is used to select the actual target address/port. If the lookup does not return a usable result, the regular connect logic kicks in (A lookup, default port). Related: https://github.com/orgs/jamulussoftware/discussions/1772
Client: Add SRV-based virtual hosting support
…eanup audiomixerboard size_t clean-up
Autobuild: Minimize permissions in CI
Copyright notices: Minimize GitHub workflow permissions
Bumps [DoozyX/clang-format-lint-action](https://github.com/DoozyX/clang-format-lint-action) from 0.14 to 0.15. - [Release notes](https://github.com/DoozyX/clang-format-lint-action/releases) - [Commits](DoozyX/clang-format-lint-action@2ec1a72...c3b2c94) --- updated-dependencies: - dependency-name: DoozyX/clang-format-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ns/DoozyX/clang-format-lint-action-0.15 Build: Bump DoozyX/clang-format-lint-action from 0.14 to 0.15
Autobuild: Minimize JSON-RPC workflow permissions
Build: Bump Qt6 from 6.4.0 to 6.4.1 (Automated PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist