fix: correctly regex esi:include tags with a blank src attribute

tags like <esi:include src="" /> cause the parser to skip over the tag and the following tag
cdloh · May 1, 2024 · 4ed7c39 · 4ed7c39
1 parent 40674a2
commit 4ed7c39
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 2 deletions.
diff --git a/src/tagParser.ts b/src/tagParser.ts
@@ -49,7 +49,7 @@ export class tagParser {
     }
 
     return new RegExp(
-      `<(${tag})(?:\\s*(?:[a-z]+=\\".+?(?<!\\\\)\\"))?[^>]*?(?:\\s*)(/>|>)?`,
+      `<(${tag})(?:\\s*(?:[a-z]+=\\".*?(?<!\\\\)\\"))?[^>]*?(?:\\s*)(/>|>)?`,
     );
   }
 
@@ -58,7 +58,7 @@ export class tagParser {
       return /(?:<(!--esi)|(-->))/;
     }
     return new RegExp(
-      `<[\\/]?(${tag})(?:\\s*(?:[a-z]+=\\".+?(?<!\\\\)\\"))?[^>]*?(?:\\s*)(\\s*/>|>)?`,
+      `<[\\/]?(${tag})(?:\\s*(?:[a-z]+=\\".*?(?<!\\\\)\\"))?[^>]*?(?:\\s*)(\\s*/>|>)?`,
     );
   }
 

diff --git a/test/esi.spec.ts b/test/esi.spec.ts
@@ -1911,3 +1911,51 @@ test("TEST 50: Multiple ESI Args make it all the way through", async () => {
     `esi_args1=1&esi_args2=2&esi_args3=3&esi_args4=4`,
   );
 });
+
+test("TEST 51: Blank ESI source should be skipped over", async () => {
+  const url = `/esi/test-51`;
+  routeHandler.add(url, function (req, res) {
+    res.writeHead(200, esiHead);
+    res.say("START:");
+    res.say(`<esi:include src="${url}/fragment_1" />`);
+    res.say(`<esi:include src="" />`);
+    res.say(`<esi:include src="${url}/fragment_1" />`);
+    res.end(`:END`);
+  });
+  routeHandler.add(
+    `${url}/fragment_1`,
+    function (req, res) {
+      res.writeHead(200, esiHead);
+      res.end(`FRAGMENT`);
+    },
+    { count: 2 },
+  );
+  const res = await makeRequest(url);
+  expect(res.ok).toBeTruthy();
+  expect(checkSurrogate(res)).toBeTruthy();
+  expect(await res.text()).toEqual(
+    `START:\nFRAGMENT\n<esi:include src="" />\nFRAGMENT\n:END`,
+  );
+});
+
+test("TEST 52: ESI drops responses with no body", async () => {
+  const url = `/esi/test-52`;
+  routeHandler.add(url, function (req, res) {
+    res.writeHead(200, esiHead);
+    res.say("START:");
+    res.say(`<esi:include src="${url}/fragment_1" />`);
+    res.end(`:END`);
+  });
+  routeHandler.add(
+    `${url}/fragment_1`,
+    function (req, res) {
+      res.writeHead(302, { Location: "http://localhost" });
+      res.end();
+    },
+    { count: 1 },
+  );
+  const res = await makeRequest(url);
+  expect(res.ok).toBeTruthy();
+  expect(checkSurrogate(res)).toBeTruthy();
+  expect(await res.text()).toEqual(`START:\n\n:END`);
+});