Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix Typescript example #293

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore: fix Typescript example #293

merged 1 commit into from
Dec 20, 2023

Conversation

shinebayar-g
Copy link
Contributor

Related issue

Fixes #

Description

Fix Typescript example in the README.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@shinebayar-g shinebayar-g requested a review from a team as a code owner December 20, 2023 08:00
@shinebayar-g shinebayar-g requested review from ansgarm and Maed223 and removed request for a team December 20, 2023 08:00
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shinebayar-g
chore: fix Typescript example
cddc5a1 
Signed-off-by: Shinebayar G <[email protected]>
@xiehan xiehan merged commit 436bd98 into cdktf:main Dec 20, 2023
11 checks passed
@shinebayar-g shinebayar-g deleted the fix-readme branch December 20, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from cdktf/tf-cdk-team

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from cdktf/tf-cdk-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shinebayar-g @hashicorp-cla @DanielMSchmidt @xiehan