chore: fix upgrade-terraform workflow #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was wondering why https://github.com/cdktf/cdktf-repository-manager/actions/runs/6450639030/job/17510215802 didn't result in a PR to upgrade to TF 1.6 and realized it's because of the quotes.
xiehan
requested review from
mutahhir and
Maed223
and removed request for
a team
[
|
[
|
[
|
[
|
|
This is going to result in the regex matching itself though, which is a problem. Don't merge this yet until I figure out a better way to do this. |
[
|
[
|
[
|
[
|
DanielMSchmidt
approved these changes
Oct 13, 2023
[
|
[
|
[
|
[
|
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why https://github.com/cdktf/cdktf-repository-manager/actions/runs/6450639030/job/17510215802 didn't result in a PR to upgrade to TF 1.6 and realized it's because of the quotes.