Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use "feat" and "fix" in changelogs to make important updates more visible #226

Merged
merged 2 commits into from
Oct 9, 2023
Merged

chore: use "feat" and "fix" in changelogs to make important updates more visible #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d0da47
chore: use "feat" and "fix" in changelogs to make important updates m…
xiehan Oct 4, 2023
277bcf9
Merge branch 'main' into better-changelogs
mergify[bot] Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/lib/collect-changes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ module.exports = async ({ core, exec }) => {
hasBreakingChanges ? "Found breaking changes!" : "No breaking changes."
);

let prefix = `chore(deps)${hasBreakingChanges ? "!" : ""}: Updated `;
let prefix = `chore(deps)${hasBreakingChanges ? "!" : ""}: update `;

let commitMessageParts = [];

Expand All @@ -123,9 +123,11 @@ module.exports = async ({ core, exec }) => {
switch (res.key) {
case "terraformProvider":
name = `provider version`;
prefix = `${hasBreakingChanges ? "feat!" : "fix"}: update `;
break;
case "cdktfVersion":
name = `CDKTF version`;
prefix = `${hasBreakingChanges ? "feat!" : "fix"}: update `;
break;
case "constructsVersion":
name = `Constructs version`;
Expand Down