Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make license holder overridable #388

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: Make license holder overridable #388

merged 2 commits into from
Jan 17, 2024

Conversation

mbialon
Copy link
Contributor

@mbialon mbialon commented Jan 5, 2024 •
edited
Loading

Related issue

Fixes #387

Description

I added an option to override the license holder.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mbialon mbialon requested a review from a team as a code owner January 5, 2024 14:47
@mbialon mbialon requested review from mutahhir and ansgarm and removed request for a team January 5, 2024 14:47
@mbialon mbialon force-pushed the feat-override-license-holder branch from af03ab8 to db2a9ac Compare January 5, 2024 14:50
@xiehan xiehan enabled auto-merge (squash) January 17, 2024 09:54
@xiehan xiehan merged commit de50451 into cdktf:main Jan 17, 2024
7 checks passed
@mbialon mbialon deleted the feat-override-license-holder branch January 17, 2024 10:01
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xiehan xiehan xiehan approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from cdktf/tf-cdk-team

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from cdktf/tf-cdk-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make license holder overridable
2 participants
@mbialon @xiehan