Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace mergify with automerge workflow #363

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

xiehan
Copy link
Contributor

@xiehan xiehan commented Nov 30, 2023

NOTE: cdktf/cdktf-repository-manager#213 must be merged before this can be safely merged

This is not as fine-grained as the mergify query but good enough
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review December 6, 2023 13:13
@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner December 6, 2023 13:13
@DanielMSchmidt DanielMSchmidt requested review from ansgarm and DanielMSchmidt and removed request for a team December 6, 2023 13:13
Signed-off-by: team-tf-cdk <[email protected]>
Copy link
Contributor

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

(not approving since it says cdktf/cdktf-repository-manager#213 should be merged first; I don't want to trigger automerge on this by an approve 😄)

@xiehan xiehan merged commit 00929b2 into main Dec 7, 2023
7 checks passed
@xiehan xiehan deleted the no-more-mergify branch December 7, 2023 12:11
Copy link

I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants