chore!: increase minimum supported Node.js version to 18 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-tf-cdk
requested review from
mutahhir and
Maed223
and removed request for
a team
team-tf-cdk
force-pushed
the
auto/upgrade-node-18
branch
2 times, most recently
from
129a7e7 to
11420c3
Compare
ansgarm
pushed a commit
that referenced
this pull request
Oct 18, 2023
Attempting to see if this will allow #347 to be merged. I've confirmed that after doing this, the node upgrade works for me locally, though who knows what will happen in CI. 🤷🏻♀️
Signed-off-by: team-tf-cdk <[email protected]>
team-tf-cdk
force-pushed
the
auto/upgrade-node-18
branch
from
11420c3 to
2b303f8
Compare
xiehan
approved these changes
Oct 18, 2023
|
I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the minimum supported Node.js version to
18.12.0from16.14.0because version 16 is less than 30 days away from EOL.