Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken upgrade-node workflow #345

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: fix broken upgrade-node workflow #345

merged 1 commit into from
Oct 17, 2023

Conversation

xiehan
Copy link
Contributor

@xiehan xiehan commented Oct 17, 2023

node-fetch needs to be pinned to v2 if we don't want to use ES modules.

@xiehan xiehan requested a review from a team as a code owner October 17, 2023 09:15
@xiehan xiehan requested review from DanielMSchmidt and Maed223 and removed request for a team October 17, 2023 09:15
@team-tf-cdk team-tf-cdk enabled auto-merge (squash) October 17, 2023 09:16
node-fetch needs to be pinned to v2 if we don't want to use ES modules.
@team-tf-cdk team-tf-cdk merged commit 3ecbd5b into main Oct 17, 2023
6 checks passed
@team-tf-cdk team-tf-cdk deleted the xiehan-patch-1 branch October 17, 2023 09:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants