fix(ci): remove invalid properties from force-release workflow (#442)

Unfortunately, the rollout of #437 failed because it turns out there was
some invalid syntax in the `force-release` workflow, which the
`action-validator` package was failing the build on. This highlighted
one flaw of this setup: because the `force-release` workflow doesn't
exist in this project, and only in the prebuilt providers / implementers
of this project, it wasn't being run through the validation at
build/test time here in the source, and so it's possible to write a bad
workflow here, publish a release, and break all implementing projects as
a result.

In order to be a good citizen, I not only fixed the issue with
`force-release` itself but also figured out how to add tests for all of
the workflows, again using `action-validator`. I manually verified that
with the bad syntax still included in `force-release.ts`, the tests were
failing (as they should). When I removed the bad syntax, all the tests
pass. Win!

src/force-release.ts

@@ -20,13 +20,11 @@ export class ForceRelease {
       workflowDispatch: {
         inputs: {
           sha: {
-            name: "sha",
             type: "string",
             required: true,
             description: "The sha of the commit to release",
           },
           publish_to_go: {
-            name: "publish_to_go",
             type: "boolean",
             required: true,
             description: "Whether to publish to Go Repository",

test/index.test.ts

@@ -3,29 +3,8 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-import { synthSnapshot } from "./utils";
-import { CdktfProviderProject, CdktfProviderProjectOptions } from "../src";
-
-const getProject = (
-  opts: Partial<CdktfProviderProjectOptions> = {}
-): CdktfProviderProject =>
-  new CdktfProviderProject({
-    terraformProvider: "random@~>2.0",
-    cdktfVersion: "0.10.3",
-    constructsVersion: "10.0.0",
-    jsiiVersion: "~5.2.0",
-    typescriptVersion: "~5.2.0", // NOTE: this should be the same major/minor version as JSII
-    devDeps: ["@cdktf/provider-project@^0.0.0"],
-    // NOTE: the below options aren't required to be passed in practice and only need to be here for the test
-    // This is because JSII prevents us from declaring the options as a Partial<cdk.JsiiProjectOptions>
-    name: "test",
-    author: "cdktf-team",
-    authorAddress: "https://github.com/cdktf",
-    defaultReleaseBranch: "main",
-    repositoryUrl: "github.com/cdktf/cdktf",
-    forceMajorVersion: 42,
-    ...opts,
-  });
+import { synthSnapshot } from "./util/synth";
+import { getProject } from "./util/test-project";
 
 test("synths with minimal options", () => {
   const snapshot = synthSnapshot(getProject());
@@ -194,7 +173,7 @@ test("override maven group id", () => {
 
 test("with minNodeVersion", () => {
   const snapshot = synthSnapshot(
-    new CdktfProviderProject({
+    getProject({
       useCustomGithubRunner: false,
       terraformProvider: "vancluever/acme@~> 2.10",
       cdktfVersion: "^0.20.0",
@@ -204,7 +183,7 @@ test("with minNodeVersion", () => {
       typescriptVersion: "~5.3.0", // NOTE: this should be the same major/minor version as JSII
       devDeps: ["@cdktf/provider-project@^0.5.0"],
       isDeprecated: false,
-    } as any)
+    })
   );
 
   expect(snapshot).toMatchSnapshot();

test/util/test-project.ts

@@ -0,0 +1,27 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+
+import { CdktfProviderProject, CdktfProviderProjectOptions } from "../../src";
+
+export const getProject = (
+  opts: Partial<CdktfProviderProjectOptions> = {}
+): CdktfProviderProject =>
+  new CdktfProviderProject({
+    terraformProvider: "random@~>2.0",
+    cdktfVersion: "0.10.3",
+    constructsVersion: "10.0.0",
+    jsiiVersion: "~5.2.0",
+    typescriptVersion: "~5.2.0", // NOTE: this should be the same major/minor version as JSII
+    devDeps: ["@cdktf/provider-project@^0.0.0"],
+    // NOTE: the below options aren't required to be passed in practice and only need to be here for the test
+    // This is because JSII prevents us from declaring the options as a Partial<cdk.JsiiProjectOptions>
+    name: "test",
+    author: "cdktf-team",
+    authorAddress: "https://github.com/cdktf",
+    defaultReleaseBranch: "main",
+    repositoryUrl: "github.com/cdktf/cdktf",
+    forceMajorVersion: 42,
+    ...opts,
+  });

test/workflows.test.ts

@@ -0,0 +1,23 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+
+import { validateWorkflow } from "@action-validator/core";
+import { GithubWorkflow } from "projen/lib/github";
+import { synthSnapshot } from "./util/synth";
+import { getProject } from "./util/test-project";
+
+const project = getProject();
+
+describe("GitHub Actions validation", () => {
+  const snapshot = synthSnapshot(getProject());
+
+  project.github!.workflows.forEach((workflow: GithubWorkflow) => {
+    test(workflow.file!.path, () => {
+      const state = validateWorkflow(snapshot[workflow.file!.path]);
+
+      expect(state.errors).toEqual([]);
+    });
+  });
+});