feat: make maven group ID overridable

cdktf · Jan 5, 2024 · a896b33 · a896b33
1 parent 2e0adcf
commit a896b33
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 2 deletions.
diff --git a/API.md b/API.md
diff --git a/src/index.ts b/src/index.ts
@@ -48,6 +48,10 @@ export interface CdktfProviderProjectOptions extends cdk.JsiiProjectOptions {
    * defaults to "hashicorp"
    */
   readonly mavenOrg?: string;
+  /**
+   * defaults to "com.${mavenOrg}"
+   */
+  readonly mavenGroupId?: string;
   /**
    * The year of the creation of the repository, for copyright purposes.
    * Will fall back to the current year if not specified.
@@ -123,7 +127,8 @@ export class CdktfProviderProject extends cdk.JsiiProject {
     const nugetName = `${nugetOrg}.${pascalCase(
       namespace
     )}.Providers.${pascalCase(providerName)}`;
-    const mavenName = `com.${mavenOrg}.${namespace}.providers.${getMavenName(
+    const mavenGroupId = options.mavenGroupId ?? `com.${mavenOrg}`;
+    const mavenName = `${mavenGroupId}.${namespace}.providers.${getMavenName(
       providerName
     )}`;
     const repositoryUrl = `github.com/${githubNamespace}/${namespace}-provider-${providerName.replace(
@@ -151,7 +156,7 @@ export class CdktfProviderProject extends cdk.JsiiProject {
       },
       publishToMaven: {
         javaPackage: mavenName,
-        mavenGroupId: `com.${mavenOrg}`,
+        mavenGroupId: mavenGroupId,
         mavenArtifactId: `${namespace}-provider-${providerName}`,
         mavenEndpoint,
       },

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -151,3 +151,29 @@ test("has a custom workflow and README if the project is deprecated", () => {
     )
   );
 });
+
+test("override maven org", () => {
+  const snapshot = synthSnapshot(getProject({ mavenOrg: "gofer" }));
+
+  expect(JSON.parse(snapshot["package.json"])).toHaveProperty(
+    "jsii.targets.java.maven.groupId",
+    "com.gofer"
+  );
+  expect(JSON.parse(snapshot["package.json"])).toHaveProperty(
+    "jsii.targets.java.package",
+    "com.gofer.cdktf.providers.random_provider"
+  );
+});
+
+test("override maven group id", () => {
+  const snapshot = synthSnapshot(getProject({ mavenGroupId: "dev.gofer" }));
+
+  expect(JSON.parse(snapshot["package.json"])).toHaveProperty(
+    "jsii.targets.java.maven.groupId",
+    "dev.gofer"
+  );
+  expect(JSON.parse(snapshot["package.json"])).toHaveProperty(
+    "jsii.targets.java.package",
+    "dev.gofer.cdktf.providers.random_provider"
+  );
+});