Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept onDestroy command to run before resource destruction #228

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

ZauberNerd
Copy link
Contributor

Related issue

Fixes #

Description

Accept an optional command via onDestroy parameter to enable running a command during destroy-time.
See also: https://developer.hashicorp.com/terraform/language/resources/provisioners/syntax#destroy-time-provisioners

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@ZauberNerd ZauberNerd requested a review from a team as a code owner July 17, 2024 20:57
@ZauberNerd ZauberNerd requested review from mutahhir and DanielMSchmidt and removed request for a team July 17, 2024 20:57
@DanielMSchmidt DanielMSchmidt merged commit 17d95a3 into cdktf:main Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants