Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default cwd to process.cwd() #227

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: default cwd to process.cwd() #227

merged 1 commit into from
Jul 22, 2024

Conversation

ZauberNerd
Copy link
Contributor

Related issue

Fixes #

Description

The jsdoc comment already mentioned that cwd defaults to process.cwd(), but that wasn't the case.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@ZauberNerd ZauberNerd requested a review from a team as a code owner July 17, 2024 19:57
@ZauberNerd ZauberNerd requested review from mutahhir and DanielMSchmidt and removed request for a team July 17, 2024 19:57
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Jul 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ZauberNerd
fix: default cwd to process.cwd()
edc3f50 
The jsdoc comment already mentioned that `cwd` defaults to
`process.cwd()`.
DanielMSchmidt
DanielMSchmidt approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help 🙇

@DanielMSchmidt DanielMSchmidt merged commit cd233a6 into cdktf:main Jul 22, 2024
7 checks passed
@ZauberNerd ZauberNerd deleted the default-cwd branch July 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from cdktf/tf-cdk-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZauberNerd @DanielMSchmidt