Skip to content

Commit

Permalink
chore: convert deny-list integ test to integ-runner (#1456)
Browse files Browse the repository at this point in the history
This became required because the SDK v3 updates every day and that
changes the asset hashes. The old style integ tests don't support
ignoring asset hash updates.

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
  • Loading branch information
mrgrain authored Sep 13, 2024
1 parent 3c10fe6 commit cec1dea
Show file tree
Hide file tree
Showing 42 changed files with 4,026 additions and 498 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 5 additions & 18 deletions .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions .npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .prettierignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

82 changes: 14 additions & 68 deletions .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 15 additions & 6 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,15 @@ const project = new CdklabsConstructLibrary({
peerDeps,

minNodeVersion: '16.16.0',
jsiiVersion: '5.4.x',

typescriptVersion: '5.4.x',
// Exclude handler images from TypeScript compiler path
excludeTypescript: ['resources/**'],
tsconfigDev: {
include: ['test/**/*.ts'],
},

jsiiVersion: '5.4.x',
rosettaOptions: {
version: '5.4.x',
},
Expand Down Expand Up @@ -139,9 +146,6 @@ const project = new CdklabsConstructLibrary({
// run tests from .js -- otherwise lambda bundlers get confused
testdir: 'src/__tests__',

// Exclude handler images from TypeScript compiler path
excludeTypescript: ['resources/**'],

autoApproveOptions: {
allowedUsernames: ['cdklabs-automation'],
secret: 'GITHUB_TOKEN',
Expand Down Expand Up @@ -173,6 +177,10 @@ const project = new CdklabsConstructLibrary({
singleQuote: true,
},
},
eslintOptions: {
dirs: [],
devdirs: ['test', 'src/__tests__'],
},

// disable some features in favor of custom implementation
// in future, we should migrate the custom code to use the provided feature
Expand All @@ -188,8 +196,9 @@ project.setScript(
'yarn dev:synth && cd lib/__tests__/devapp && npx cdk-dia && mv diagram.png ../../../diagrams/diagram.png'
);

project.addGitIgnore('!/test/fixtures/tests/package.tgz');
project.addGitIgnore('/test/integ.transliterator.ecstask.ts.snapshot/asset.*');
project.addPackageIgnore('/test');
project.addGitIgnore('!/test/fixtures/**');
project.addGitIgnore('/test/*.snapshot/asset.*');
project.addGitIgnore('!/src/third-party-types/*');

project.package.addField('resolutions', {
Expand Down
Loading

0 comments on commit cec1dea

Please sign in to comment.