feat: expose concurrency at GitHub workflow level #903
Conversation
There was a problem hiding this comment.
Thanks for the PR @zezke! I have a few comments, also I would love for you to add this feature to the readme. also, ideally you don't open a PR directly from your main branch. I would rather you close this PR, open a new branch, address the feedback, and then create a PR from the branch itself. This will by default give us the right permissions to push to your branch (we can't push to your main).
test/github.test.ts
Outdated
| console.log(github.workflowPath); | ||
| console.log(github.workflowPath); | ||
| console.log(github.workflowPath); | ||
| console.log(github.workflowPath); |
There was a problem hiding this comment.
Is this part of the concurrency test? how? please document otherwise next time i look at this i will laugh and then delete...
src/workflows-model.ts
Outdated
| /** | ||
| * Conditionally cancel currently running jobs or workflows in the same concurrency group | ||
| */ | ||
| readonly cancelInProgress?: boolean; |
There was a problem hiding this comment.
add a default here. probably false?
src/workflows-model.ts
Outdated
| @@ -956,3 +956,17 @@ export interface PublicOptions { } | |||
| */ | |||
| export interface StatusOptions { } | |||
| //#endregion | |||
|
|
|||
| /** | |||
| * Concurrency options | |||
There was a problem hiding this comment.
Can we link to the relevant github documentation please
This PR adds a concurrency setting on workflow level, preventing multiple workflows run in parallel which our pipeline does not like.